Commit ef104f29 authored by perezju's avatar perezju Committed by Commit bot

[tools/perf] Explicitly disable state tear down on some benchmarks

We're planning to switch the default of ShouldTearDownStateAfterEachStoryRun
to True; but some benchmarks would not work under that setting.

BUG=640990

Review-Url: https://codereview.chromium.org/2301383002
Cr-Commit-Position: refs/heads/master@{#416383}
parent 1f0a7bb6
...@@ -61,6 +61,10 @@ class MemoryBenchmarkTop10Mobile(_MemoryInfra): ...@@ -61,6 +61,10 @@ class MemoryBenchmarkTop10Mobile(_MemoryInfra):
def Name(cls): def Name(cls):
return 'memory.top_10_mobile' return 'memory.top_10_mobile'
@classmethod
def ShouldTearDownStateAfterEachStoryRun(cls):
return False
@classmethod @classmethod
def ShouldDisable(cls, possible_browser): def ShouldDisable(cls, possible_browser):
# TODO(crbug.com/586148): Benchmark should not depend on DeskClock app. # TODO(crbug.com/586148): Benchmark should not depend on DeskClock app.
...@@ -107,6 +111,10 @@ class DualBrowserBenchmark(_MemoryInfra): ...@@ -107,6 +111,10 @@ class DualBrowserBenchmark(_MemoryInfra):
def Name(cls): def Name(cls):
return 'memory.dual_browser_test' return 'memory.dual_browser_test'
@classmethod
def ShouldTearDownStateAfterEachStoryRun(cls):
return False
@classmethod @classmethod
def ValueCanBeAddedPredicate(cls, value, is_first_result): def ValueCanBeAddedPredicate(cls, value, is_first_result):
# TODO(crbug.com/610962): Remove this stopgap when the perf dashboard # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
...@@ -129,6 +137,10 @@ class LongRunningDualBrowserBenchmark(_MemoryInfra): ...@@ -129,6 +137,10 @@ class LongRunningDualBrowserBenchmark(_MemoryInfra):
def Name(cls): def Name(cls):
return 'memory.long_running_dual_browser_test' return 'memory.long_running_dual_browser_test'
@classmethod
def ShouldTearDownStateAfterEachStoryRun(cls):
return False
@classmethod @classmethod
def ShouldTearDownStateAfterEachStorySetRun(cls): def ShouldTearDownStateAfterEachStorySetRun(cls):
return False return False
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment