Commit ef19cb54 authored by Julia Tuttle's avatar Julia Tuttle Committed by Commit Bot

Reporting: Log 'JSON too big' HeaderOutcome

Change-Id: I75ecc7e893dfababd7669554433e674d77d95c1a
Reviewed-on: https://chromium-review.googlesource.com/953502
Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
Reviewed-by: default avatarRobert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543732}
parent e7bba458
...@@ -26,8 +26,9 @@ enum class HeaderOutcome { ...@@ -26,8 +26,9 @@ enum class HeaderOutcome {
DISCARDED_NO_REPORTING_SERVICE = 0, DISCARDED_NO_REPORTING_SERVICE = 0,
DISCARDED_INVALID_SSL_INFO = 1, DISCARDED_INVALID_SSL_INFO = 1,
DISCARDED_CERT_STATUS_ERROR = 2, DISCARDED_CERT_STATUS_ERROR = 2,
DISCARDED_INVALID_JSON = 3, DISCARDED_JSON_INVALID = 3,
PARSED = 4, PARSED = 4,
DISCARDED_JSON_TOO_BIG = 5,
MAX MAX
}; };
...@@ -239,8 +240,13 @@ void ReportingHeaderParser::RecordHeaderDiscardedForCertStatusError() { ...@@ -239,8 +240,13 @@ void ReportingHeaderParser::RecordHeaderDiscardedForCertStatusError() {
} }
// static // static
void ReportingHeaderParser::RecordHeaderDiscardedForInvalidJson() { void ReportingHeaderParser::RecordHeaderDiscardedForJsonInvalid() {
RecordHeaderOutcome(HeaderOutcome::DISCARDED_INVALID_JSON); RecordHeaderOutcome(HeaderOutcome::DISCARDED_JSON_INVALID);
}
// static
void ReportingHeaderParser::RecordHeaderDiscardedForJsonTooBig() {
RecordHeaderOutcome(HeaderOutcome::DISCARDED_JSON_TOO_BIG);
} }
// static // static
......
...@@ -25,7 +25,8 @@ class NET_EXPORT ReportingHeaderParser { ...@@ -25,7 +25,8 @@ class NET_EXPORT ReportingHeaderParser {
static void RecordHeaderDiscardedForNoReportingService(); static void RecordHeaderDiscardedForNoReportingService();
static void RecordHeaderDiscardedForInvalidSSLInfo(); static void RecordHeaderDiscardedForInvalidSSLInfo();
static void RecordHeaderDiscardedForCertStatusError(); static void RecordHeaderDiscardedForCertStatusError();
static void RecordHeaderDiscardedForInvalidJson(); static void RecordHeaderDiscardedForJsonInvalid();
static void RecordHeaderDiscardedForJsonTooBig();
static void ParseHeader(ReportingContext* context, static void ParseHeader(ReportingContext* context,
const GURL& url, const GURL& url,
......
...@@ -54,7 +54,7 @@ class ReportingServiceImpl : public ReportingService { ...@@ -54,7 +54,7 @@ class ReportingServiceImpl : public ReportingService {
base::BindRepeating(&ReportingServiceImpl::ProcessHeaderValue, base::BindRepeating(&ReportingServiceImpl::ProcessHeaderValue,
weak_factory_.GetWeakPtr(), url), weak_factory_.GetWeakPtr(), url),
base::BindRepeating( base::BindRepeating(
&ReportingHeaderParser::RecordHeaderDiscardedForInvalidJson)); &ReportingHeaderParser::RecordHeaderDiscardedForJsonInvalid));
} }
void RemoveBrowsingData(int data_type_mask, void RemoveBrowsingData(int data_type_mask,
......
...@@ -37979,8 +37979,9 @@ Called by update_net_trust_anchors.py.--> ...@@ -37979,8 +37979,9 @@ Called by update_net_trust_anchors.py.-->
<int value="0" label="Discarded: no ReportingService"/> <int value="0" label="Discarded: no ReportingService"/>
<int value="1" label="Discarded: invalid SSLInfo"/> <int value="1" label="Discarded: invalid SSLInfo"/>
<int value="2" label="Discarded: cert status error"/> <int value="2" label="Discarded: cert status error"/>
<int value="3" label="Discarded: invalid JSON"/> <int value="3" label="Discarded: JSON invalid"/>
<int value="4" label="Parsed"/> <int value="4" label="Parsed"/>
<int value="5" label="Discarded: JSON too big"/>
</enum> </enum>
<enum name="ReportingReportOutcome"> <enum name="ReportingReportOutcome">
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment