Skip to content

GitLab

T
tangled
Commit ef2407f8 authored by Simon Zünd's avatar Simon Zünd Committed by Commit Bot
Browse files
Options

[devtools] Remove elements panel CSS web test that was ported to e2e 

The force-pseudo-state.js web test was ported to an devtools e2e in:
  * https://crrev.com/c/2095297
  * https://crrev.com/c/2096706

As the web test is flaky and disabled on most platforms, its better
to only rely on the e2e test and remove the web test altogether.

R=tvanderlippe@chromium.org

Bug: chromium:1060270
Change-Id: I130200ced1d7e4f2c4be84be5a7e2445c56f5f14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098626
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: default avatarTim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749604}
parent 016fe21f
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 187 deletions
third_party/blink/web_tests/TestExpectations
View file @ ef2407f8
......@@ -6004,8 +6004,6 @@ crbug.com/994008 [ Linux ] http/tests/devtools/elements/styles-3/styles-computed
crbug.com/994008 [ Win ] http/tests/devtools/elements/styles-3/styles-computed-trace.js [ Pass Failure Timeout ]
crbug.com/994034 [ Linux ] http/tests/devtools/elements/styles-3/styles-add-new-rule-colon.js [ Pass Failure Timeout ]
crbug.com/994034 [ Win ] http/tests/devtools/elements/styles-3/styles-add-new-rule-colon.js [ Pass Failure Timeout ]
crbug.com/994027 [ Linux ] http/tests/devtools/elements/styles-2/force-pseudo-state.js [ Pass Failure Timeout ]
crbug.com/994027 [ Win ] http/tests/devtools/elements/styles-2/force-pseudo-state.js [ Pass Failure Timeout ]
crbug.com/995142 crbug.com/900706 [ Mac ] virtual/gpu/fast/canvas/pixelated-canvas.html [ Pass Failure ]
crbug.com/995142 crbug.com/900706 [ Mac ] virtual/gpu/fast/canvas/pixelated-resize.html [ Pass Failure ]
crbug.com/995142 crbug.com/900706 [ Mac ] virtual/gpu/fast/canvas/pixelated.html [ Pass Failure ]
......@@ -7018,9 +7016,6 @@ crbug.com/1060175 [ Win ] wpt_internal/storage/estimate-usage-details-filesystem
crbug.com/1060175 [ Win ] wpt_internal/virtual-scroller/large-child-comment.html [ Pass Failure ]
crbug.com/1060175 [ Win ] wpt_internal/webxr/xr_view_projection_detached.https.html [ Pass Failure ]
# Note: This is disabled on other platforms already.
crbug.com/1060270 [ Mac ] http/tests/devtools/elements/styles-2/force-pseudo-state.js [ Failure ]
# Temporarily disable to land https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2090785
crbug.com/1011811 third_party/blink/web_tests/http/tests/devtools/changes/changes-sidebar.js [ Pass Failure ]
crbug.com/1011811 third_party/blink/web_tests/http/tests/devtools/search/search-in-static.js [ Pass Failure ]
......
third_party/blink/web_tests/http/tests/devtools/elements/styles-2/force-pseudo-state-expected.txt deleted 100644 → 0
View file @ 016fe21f
Tests that forced element state is reflected in the DOM tree and Styles pane.
DIV with :hover and :active
[expanded]
element.style { ()
[expanded]
div:active, a:active { (<style>)
font-weight: bold;
[expanded]
div:hover, a:hover { (<style>)
color: red;
[expanded]
div { (user agent stylesheet)
display: block;
======== Inherited from body#mainBody.main1.main2.mainpage ========
[expanded]
Style Attribute { ()
/-- overloaded --/ font-weight: normal;
- <html> [subtreeMarkerCount:1]
+ <head>…</head>
- <body id="mainBody" class="main1 main2 mainpage" style="font-weight: normal; width: 85%; background-image: url(bar.png)"> [subtreeMarkerCount:1]
<div id="div">Test text</div> [markers:[pseudo-state-marker=hover,active], subtreeMarkerCount:1]
</body>
</html>
DIV with :active and :focus
[expanded]
element.style { ()
[expanded]
div:active, a:active { (<style>)
font-weight: bold;
[expanded]
div:focus, a:focus { (<style>)
border: 1px solid green;
border-top-color: green;
border-top-style: solid;
border-top-width: 1px;
border-right-color: green;
border-right-style: solid;
border-right-width: 1px;
border-bottom-color: green;
border-bottom-style: solid;
border-bottom-width: 1px;
border-left-color: green;
border-left-style: solid;
border-left-width: 1px;
border-image-source: initial;
border-image-slice: initial;
border-image-width: initial;
border-image-outset: initial;
border-image-repeat: initial;
[expanded]
:focus { (user agent stylesheet)
outline: -webkit-focus-ring-color auto 1px;
outline-color: -webkit-focus-ring-color;
outline-style: auto;
outline-width: 1px;
[expanded]
div { (user agent stylesheet)
display: block;
======== Inherited from body#mainBody.main1.main2.mainpage ========
[expanded]
Style Attribute { ()
/-- overloaded --/ font-weight: normal;
- <html> [subtreeMarkerCount:1]
+ <head>…</head>
- <body id="mainBody" class="main1 main2 mainpage" style="font-weight: normal; width: 85%; background-image: url(bar.png)"> [subtreeMarkerCount:1]
<div id="div">Test text</div> [markers:[pseudo-state-marker=active,focus], subtreeMarkerCount:1]
</body>
</html>
DIV with no forced state
[expanded]
element.style { ()
[expanded]
div { (user agent stylesheet)
display: block;
======== Inherited from body#mainBody.main1.main2.mainpage ========
[expanded]
Style Attribute { ()
font-weight: normal;
- <html>
+ <head>…</head>
- <body id="mainBody" class="main1 main2 mainpage" style="font-weight: normal; width: 85%; background-image: url(bar.png)">
<div id="div">Test text</div>
</body>
</html>
third_party/blink/web_tests/http/tests/devtools/elements/styles-2/force-pseudo-state.js deleted 100644 → 0
View file @ 016fe21f
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
(async function() {
TestRunner.addResult(`Tests that forced element state is reflected in the DOM tree and Styles pane.\n`);
await TestRunner.loadModule('elements_test_runner');
await TestRunner.showPanel('elements');
await TestRunner.loadHTML(`
<head>
<style>
div:hover, a:hover {
color: red;
}
div:focus, a:focus {
border: 1px solid green;
}
div:active, a:active {
font-weight: bold;
}
</style>
</head>
<body id="mainBody" class="main1 main2 mainpage" style="font-weight: normal; width: 85%; background-image: url(bar.png)">
<div id="div">Test text</div>
</body>
`);
ElementsTestRunner.nodeWithId('div', foundDiv);
var divNode;
async function dumpData() {
await ElementsTestRunner.dumpSelectedElementStyles(true);
ElementsTestRunner.dumpElementsTree();
}
function foundDiv(node) {
divNode = node;
TestRunner.cssModel.forcePseudoState(divNode, 'hover', true);
TestRunner.cssModel.forcePseudoState(divNode, 'active', true);
ElementsTestRunner.selectNodeAndWaitForStyles('div', divSelected1);
}
async function divSelected1() {
TestRunner.addResult('');
TestRunner.addResult('DIV with :hover and :active');
await dumpData();
ElementsTestRunner.waitForStyles('div', hoverCallback, true);
TestRunner.cssModel.forcePseudoState(divNode, 'hover', false);
function hoverCallback() {
ElementsTestRunner.waitForStyles('div', divSelected2, true);
TestRunner.cssModel.forcePseudoState(divNode, 'focus', true);
}
}
async function divSelected2() {
TestRunner.addResult('');
TestRunner.addResult('DIV with :active and :focus');
await dumpData();
ElementsTestRunner.waitForStyles('div', focusCallback, true);
TestRunner.cssModel.forcePseudoState(divNode, 'focus', false);
function focusCallback() {
ElementsTestRunner.waitForStyles('div', divSelected3, true);
TestRunner.cssModel.forcePseudoState(divNode, 'active', false);
}
}
async function divSelected3(node) {
TestRunner.addResult('');
TestRunner.addResult('DIV with no forced state');
await dumpData();
TestRunner.completeTest();
}
})();
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment