Stop passing chrome.test.fail as ErrorCallback

chrome.test.fail cannot be used as ErrorCallback because it throws exception when the number of arguments doesn't match.
This wrong use of chrome.test.fail makes the error output useless when something goes wrong.

BUG=None
TEST=browser_tests

Review URL: https://codereview.chromium.org/258523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266271 0039d316-1c4b-4281-b951-d872f2087c98

chrome/test/data/extensions/api_test/file_browser/app_file_handler/background.js

@@ -34,8 +34,9 @@ function readFileAndExpectContent(entry, expectedContent) {
       chrome.test.fail('Error reading file contents.');
     };
     reader.readAsText(file);
-  },
-  chrome.test.fail.bind(null, 'Unable to get file snapshot.'));
+  }, function(error) {
+    chrome.test.fail('Unable to get file snapshot: ' + error.name);
+  });
 }
 
 /**

chrome/test/data/extensions/api_test/file_browser/drive_search_test/test.js

@@ -47,8 +47,9 @@ function verifyDirectory(entry, successCallback) {
                           'Entry has no createReader method.');
   var reader = entry.createReader();
 
-  reader.readEntries(successCallback,
-                     chrome.test.fail.bind(null, 'Error reading directory.'));
+  reader.readEntries(successCallback, function (error) {
+    chrome.test.fail('Error reading directory: ' + error.name);
+  });
 }
 
 /**

chrome/test/data/extensions/api_test/file_browser/file_browser_handler/background.js

@@ -109,10 +109,9 @@ function readTest(entry, expectSuccess) {
 function getSiblingTest(entry) {
   var error = 'Got file (\'' + entry.fullPath.concat('.foo') + '\') for which' +
               'file access was not granted.';
-  entry.filesystem.root.getFile(
-      entry.fullPath.concat('.foo'), {},
-      chrome.test.fail.bind(null, error),
-      chrome.test.succeed);
+  entry.filesystem.root.getFile(entry.fullPath.concat('.foo'), {},
+                                function(entry) { chrome.test.fail(error); },
+                                chrome.test.succeed);
 }
 
 /**

chrome/test/data/extensions/api_test/file_browser/file_browser_handler_lazy/background.js

@@ -112,10 +112,9 @@ function readTest(entry, expectSuccess) {
 function getSiblingTest(entry) {
   var error = 'Got file (\'' + entry.fullPath.concat('.foo') + '\') for which' +
               'file access was not granted.';
-  entry.filesystem.root.getFile(
-      entry.fullPath.concat('.foo'), {},
-      chrome.test.fail.bind(null, error),
-      chrome.test.succeed);
+  entry.filesystem.root.getFile(entry.fullPath.concat('.foo'), {},
+                                function (entry) { chrome.test.fail(error); },
+                                chrome.test.succeed);
 }
 
 /**

chrome/test/data/extensions/api_test/file_browser/filesystem_operations_test/test.js

@@ -103,10 +103,13 @@ function readFileAndExpectContent(
     reader.onload = function() {
       assertEqAndRunCallback(expectedContent, reader.result, message, callback);
     };
-    reader.onerror = chrome.test.fail.bind(null, 'Reading file.');
-
+    reader.onerror = function(event) {
+      chrome.test.fail('Failed to read: ' + reader.error.name);
+    };
     entry.file(reader.readAsText.bind(reader),
-               chrome.test.fail.bind(null, 'Getting file.'));
+               function(error) {
+                 chrome.test.fail('Failed to get file: ' + error.name);
+               });
   });
 }
 
@@ -149,8 +152,9 @@ function abortWriteFile(volumeId, entry, path, callback) {
       }
 
       writer.write(new Blob(['xxxxx'], {'type': 'text/plain'}));
-    },
-    chrome.test.fail.bind(null, 'Error creating writer.'));
+    }, function(error) {
+      chrome.test.fail('Error creating writer: ' + error.name);
+    });
   });
 }
 
@@ -190,8 +194,9 @@ function abortTruncateFile(volumeId, entry, path, callback) {
       }
 
       writer.truncate(10);
-    },
-    chrome.test.fail.bind(null, 'Error creating writer.'));
+    }, function(error) {
+      chrome.test.fail('Error creating writer: ' + error.name);
+    });
   });
 }
 

chrome/test/data/extensions/api_test/media_galleries/common/common_injected.js

@@ -202,7 +202,7 @@ function verifyDirectoryEntry(directoryEntry, verifyFunction) {
 function verifyJPEG(parentDirectoryEntry, filename, expectedFileLength,
                     doneCallback) {
   function verifyFileEntry(fileEntry) {
-    fileEntry.file(verifyFile, chrome.test.fail)
+    fileEntry.file(verifyFile, chrome.test.fail);
   }
 
   function verifyFile(file) {
@@ -212,10 +212,11 @@ function verifyJPEG(parentDirectoryEntry, filename, expectedFileLength,
       var arraybuffer = e.target.result;
       chrome.test.assertEq(expectedFileLength, arraybuffer.byteLength);
       doneCallback();
-    }
+    };
 
-    reader.onerror =
-      chrome.test.fail.bind(null, "Unable to read test image: " + filename);
+    reader.onerror = function(e) {
+      chrome.test.fail("Unable to read test image: " + filename);
+    };
 
     reader.readAsArrayBuffer(file);
   }