Commit ef61c9e7 authored by Fergus Dall's avatar Fergus Dall Committed by Commit Bot

Expand FailureClasses for CrostiniStabilityMonitor

These new classes are recorded by cicerone, but they still need to be
recorded in enums.xml to give them names. Also update the enum in
crostini_stability_monitor.h to keep things in sync.

Bug: 977201
Change-Id: Ia7d1349fdaf8f2790f9896933d45dbc3ef5918be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272620Reviewed-by: default avatarNicholas Verne <nverne@chromium.org>
Commit-Queue: Fergus Dall <sidereal@google.com>
Cr-Commit-Position: refs/heads/master@{#783893}
parent 2956d18f
......@@ -19,14 +19,27 @@ extern const char kCrostiniStabilityHistogram[];
// These values are logged to UMA. Entries should not be renumbered and numeric
// values should never be reused. Please keep in sync with
// CrostiniFailureClasses in src/tools/metrics/histograms/enums.xml.
// CrostiniFailureClasses in src/tools/metrics/histograms/enums.xml and the copy
// in src/platform2/vm_tools/cicerone/crash_listener_impl.cc
enum class FailureClasses {
ConciergeStopped = 0,
CiceroneStopped = 1,
SeneschalStopped = 2,
ChunneldStopped = 3,
VmStopped = 4,
kMaxValue = VmStopped,
VmSyslogStopped = 5,
VshdStopped = 6,
LxcFsStopped = 7,
TremplinStopped = 8,
NdproxydStopped = 9,
McastdStopped = 10,
LxdStopped = 11,
GarconStopped = 12,
SommelierStopped = 13,
SommelierXStopped = 14,
CrosSftpStopped = 15,
CrosNotificationdStopped = 16,
kMaxValue = CrosNotificationdStopped,
};
class CrostiniStabilityMonitor : chromeos::ConciergeClient::Observer,
......
......@@ -13656,11 +13656,23 @@ to ensure that the crash string is shown properly on the user-facing crash UI.
</enum>
<enum name="CrostiniFailureClasses">
<int value="0" label="Concierge stopped"/>
<int value="1" label="Cicerone stopped"/>
<int value="2" label="Seneschal stopped"/>
<int value="3" label="Chunneld stopped"/>
<int value="4" label="VM hypervisor stopped"/>
<int value="0" label="Concierge"/>
<int value="1" label="Cicerone"/>
<int value="2" label="Seneschal"/>
<int value="3" label="Chunneld"/>
<int value="4" label="VM hypervisor"/>
<int value="5" label="In-VM syslog daemon"/>
<int value="6" label="VM ssh daemon"/>
<int value="7" label="LXCFS daemon"/>
<int value="8" label="Tremplin"/>
<int value="9" label="Ndproxyd"/>
<int value="10" label="Mcastd"/>
<int value="11" label="Lxd"/>
<int value="12" label="Garcon"/>
<int value="13" label="Sommelier wayland proxy"/>
<int value="14" label="Sommelier X11 proxy"/>
<int value="15" label="Cros-Sftp"/>
<int value="16" label="Cros-Notificationd"/>
</enum>
<enum name="CrostiniImportContainerResult">
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment