Reland "Standardize feed android resources"
This reverts commit 807fab79. Reason for revert: Culprit was errorprone update this morning, which happened after trybot runs for this CL. Original change's description: > Revert "Standardize feed android resources" > > This reverts commit 0e853eb9. > > Reason for revert: Suspect culprit for build failure > > Sample failure: > https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/8660 > > Original change's description: > > Standardize feed android resources > > > > - Restructure to match chrome/browser/java/res > > - Replace strings with references to existing .grd strings > > - I kept Piet resources separate, since piet may eventually be moved into > > a different library. > > - Move feed/library sources into chrome_java > > > > Strings changed: > > snackbar_fetch_no_new_suggestions -> ntp_suggestions_fetch_no_new_suggestions > > snackbar_fetch_failed -> ntp_suggestions_fetch_failed > > snackbar_default_action -> undo > > > > It looks like chromium's strings are translated to more languages, so > > this might provide better localization. Some of these strings are > > translated differently between feed and zine. > > > > Bug: 1024945 > > Change-Id: If9862a4965756e28ba812bf315556d6b8db09e62 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956275 > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Reviewed-by: Peter Wen <wnwen@chromium.org> > > Reviewed-by: Theresa <twellington@chromium.org> > > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > > Commit-Queue: Dan H <harringtond@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#734575} > > TBR=wnwen@chromium.org,dtrainor@chromium.org,twellington@chromium.org,govind@chromium.org,megjablon@chromium.org,carlosk@chromium.org,harringtond@chromium.org > > Change-Id: I3c14db8a0c67bf5b784955df6241443489b5b8af > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1024945 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015411 > Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org> > Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734596} TBR=wnwen@chromium.org,dtrainor@chromium.org,twellington@chromium.org,govind@chromium.org,megjablon@chromium.org,carlosk@chromium.org,seblalancette@chromium.org,harringtond@chromium.org Change-Id: Ie6d83d3cf8d802a70cc73e4a24b0872d3b04ae17 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1024945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017944Reviewed-by:Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#734597}
Showing
chrome/android/feed/BUILD.gn
0 → 100644
File moved
File moved
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
Please register or sign in to comment