[CrOS Settings] Remove SettingsSectionName enum

After design discussions with jamescook@, we've decided to remove this
enum, since it's not strictly needed for the metrics we're trying to
compute (number of navigations until a setting has changed). This
complexity is unnecessary at this time.

Bug: 1047062
Change-Id: I6280115e051f9bbd67434e5a5faf25c1bc03854d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040913
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739028}

chrome/browser/resources/settings/chromeos/os_route.js

@@ -5,8 +5,6 @@
 cr.define('settings', function() {
   /**
    * Creates Route objects for each path corresponding to CrOS settings content.
-   * Note that if any new routes are added here, they should also be added to
-   * //chrome/browser/ui/webui/settings/chromeos/search/search.mojom.
    * @return {!SettingsRoutes}
    */
   function createOSSettingsRoutes() {

chrome/browser/ui/webui/settings/chromeos/search/search.mojom

@@ -4,78 +4,6 @@
 
 module chromeos.settings.mojom;
 
-// All routes in Chrome OS settings; most represent a page in the UI. This list
-// should stay in sync with the entries in
-// //chrome/browser/resources/settings/chromeos/os_route.js.
-enum SettingsSectionName {
-  // kAbout is the About page, and kAboutAbout is the subpage embedded within
-  // the page.
-  kAbout,
-  kAboutAbout,
-  kAboutDetails,
-  kAccessibility,
-  kAccessibilityManage,
-  kAccessibilityManageCaptions,
-  kAccessibilityManageSwitchAccess,
-  kAccessibilityManageTts,
-  // Bottom portion of the settings page which includes less common features
-  // (i.e., not a distinct page to visit).
-  kAdvanced,
-  kAdvancedPrivacy,
-  kApps,
-  kAppsAndroidAppsDetails,
-  kAppsManagement,
-  kAppsManagementDetails,
-  kBluetooth,
-  kBluetoothDevices,
-  kCrostini,
-  kCrostiniAndroidAdb,
-  kCrostiniDetails,
-  kCrostiniDetailsExportImport,
-  kCrostiniDetailsSharedPaths,
-  kCrostiniDetailsSharedUsbDevices,
-  kDateTime,
-  kDateTimeTimezone,
-  kDevice,
-  kDeviceDisplay,
-  kDeviceExternalStorage,
-  kDeviceKeyboard,
-  kDevicePointers,
-  kDevicePower,
-  kDeviceStorage,
-  kDeviceStylus,
-  kFiles,
-  kFilesSmbShares,
-  kInternet,
-  kInternetKnownNetworks,
-  kInternetNetworks,
-  kInternetNewtorkDetail,
-  kLanguages,
-  kLanguagesDetails,
-  kLanguagesDetailsInputMethods,
-  kMultidevice,
-  kMultideviceFeatures,
-  kMultideviceSmartLock,
-  kPeople,
-  kPeopleAccounts,
-  kPeopleKerberos,
-  kPeopleLockScreen,
-  kPeopleLockScreenFingerprint,
-  kPeopleSync,
-  kPeopleSyncAdvanced,
-  kPersonalization,
-  kPersonalizationChangePicture,
-  kPluginVm,
-  kPluginVmDetails,
-  kPluginVmSharedPaths,
-  kPrinting,
-  kPrintingCupsPrinters,
-  kReset,
-  kSearch,
-  kSearchGoogleAssistant,
-  kSignOut
-};
-
 // Types of visibility which apply to the Chrome OS settings window.
 enum SettingsPageVisibility {
   kVisibleAndFocused,

chrome/browser/ui/webui/settings/chromeos/search/settings_user_action.cc

@@ -35,9 +35,8 @@ SettingsClickAction::~SettingsClickAction() = default;
 
 // SettingsNavigationAction:
 
-SettingsNavigationAction::SettingsNavigationAction(
-    mojom::SettingsSectionName section_name)
-    : SettingsUserAction(Type::kNavigation), section_name_(section_name) {}
+SettingsNavigationAction::SettingsNavigationAction()
+    : SettingsUserAction(Type::kNavigation) {}
 
 SettingsNavigationAction::SettingsNavigationAction(
     const SettingsNavigationAction& other) = default;

chrome/browser/ui/webui/settings/chromeos/search/settings_user_action.h

@@ -52,15 +52,10 @@ class SettingsClickAction : public SettingsUserAction {
 // A navigation action taken by a user in Chrome OS settings.
 class SettingsNavigationAction : public SettingsUserAction {
  public:
-  explicit SettingsNavigationAction(mojom::SettingsSectionName section_name);
+  SettingsNavigationAction();
   SettingsNavigationAction(const SettingsNavigationAction& other);
   SettingsNavigationAction& operator=(const SettingsNavigationAction& other);
   ~SettingsNavigationAction();
-
-  mojom::SettingsSectionName section_name() const { return section_name_; }
-
- private:
-  mojom::SettingsSectionName section_name_;
 };
 
 // A visibility change action taken by a user in Chrome OS settings.