Place new version of ResizeObserver::observe behind runtime flag

Put new implementation of ResizeObserver::observe behind ResizeObserverUpdates flag to prevent compat issues until the final version of Resize Observer is shipped. No JavaScript error shold be thrown when unsupported second argument is passed to ResizeObserver::observe(). Issue was introduced in the following CL: http://crrev.com/c/2004051 Bug: 1056535 Change-Id: I7e6d319d14f9d318e0f68ea3e056cfa27eb7f937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077280 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#750235}

Place new version of ResizeObserver::observe behind runtime flag
Put new implementation of ResizeObserver::observe behind ResizeObserverUpdates flag to prevent compat issues until the final version of Resize Observer is shipped. No JavaScript error shold be thrown when unsupported second argument is passed to ResizeObserver::observe(). Issue was introduced in the following CL: http://crrev.com/c/2004051 Bug: 1056535 Change-Id: I7e6d319d14f9d318e0f68ea3e056cfa27eb7f937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077280 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#750235}
ef91311b · Sahir Vellani · Commit Bot · 8881a9a3 · ef91311b · ef91311b
Commit ef91311b authored Mar 13, 2020 by Sahir Vellani Committed by Commit Bot Mar 13, 2020
4 changed files
--- a/third_party/blink/renderer/core/resize_observer/resize_observer.idl
+++ b/third_party/blink/renderer/core/resize_observer/resize_observer.idl
@@ -13,7 +13,8 @@ callback ResizeObserverCallback = void (sequence<ResizeObserverEntry> entries, R
    ActiveScriptWrappable
 ] interface ResizeObserver {
    [CallWith=Document, MeasureAs=ResizeObserver_Constructor] constructor(ResizeObserverCallback callback);
-    void observe(Element target, optional ResizeObserverOptions options);
+    [RuntimeEnabled=ResizeObserverUpdates] void observe(Element target, ResizeObserverOptions options);
+    void observe(Element target);
    void unobserve(Element target);
    void disconnect();
 };
--- a/third_party/blink/web_tests/VirtualTestSuites
+++ b/third_party/blink/web_tests/VirtualTestSuites
@@ -95,6 +95,7 @@
              "http/tests/serviceworker/webexposed",
              "inspector-protocol/dom-snapshot",
              "media/stable",
+              "resize-observer",
              "webexposed"],
    "args": ["--stable-release-mode"]
  },

--- a/third_party/blink/web_tests/virtual/stable/resize-observer/README.txt
+++ b/third_party/blink/web_tests/virtual/stable/resize-observer/README.txt
+# This suite runs the test in resize-observer/ with --stable-release-mode, with which
+# we run tests with only stable feature (no experiments).
+# See the virtual_test_suites() method in tools/blinkpy/web_tests/port/base.py.
--- a/third_party/blink/web_tests/virtual/stable/resize-observer/observe_compat.html
+++ b/third_party/blink/web_tests/virtual/stable/resize-observer/observe_compat.html
+<!doctype HTML>
+<script src="../../../resources/testharness.js"></script>
+<script src="../../../resources/testharnessreport.js"></script>
+
+<style>
+  div {
+    width: 100px;
+    height: 100px;
+  }
+</style>
+<div id="observeme"></div>
+
+<script>
+//Ensure no error is thrown, second argument in observe() is ignored
+test(() => {
+
+  new ResizeObserver(entries => {
+
+  }).observe(observeme, "TEST");
+
+  observeme.style.height = "110px";
+}, "No error is thrown when observe() is called");
+</script>