[ios] Fixed memory cycle in password search

Thanks pkl@ for spotting this.

Bug: 898678
Change-Id: I74d2a11e89b62fef5a2a0c42f4d6b7c4d5d1519e
Reviewed-on: https://chromium-review.googlesource.com/c/1298720
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603013}

ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm

@@ -831,12 +831,14 @@ blacklistedFormItemWithText:(NSString*)text
     if (!strongSelf)
       return;
     [strongSelf clearSectionWithIdentifier:SectionIdentifierSavedPasswords
-                                   ifEmpty:savedForms_.empty()];
-    [strongSelf clearSectionWithIdentifier:SectionIdentifierBlacklist
-                                   ifEmpty:blacklistedForms_.empty()];
-    [strongSelf clearSectionWithIdentifier:SectionIdentifierSearchPasswordsBox
-                                   ifEmpty:savedForms_.empty() &&
-                                           blacklistedForms_.empty()];
+                                   ifEmpty:strongSelf->savedForms_.empty()];
+    [strongSelf
+        clearSectionWithIdentifier:SectionIdentifierBlacklist
+                           ifEmpty:strongSelf->blacklistedForms_.empty()];
+    [strongSelf
+        clearSectionWithIdentifier:SectionIdentifierSearchPasswordsBox
+                           ifEmpty:strongSelf->savedForms_.empty() &&
+                                   strongSelf->blacklistedForms_.empty()];
   }
       completion:^(BOOL finished) {
         SavePasswordsCollectionViewController* strongSelf = weakSelf;