Provide default implementation for BookmarkClient::PreferTouchIcon

The reason to provide default implementations for these methods
is that so an embedder that wants to use bookmarks and doesn't need/want
favicons or omnibox-related methods doesn't even have to think about what
to provide as implementations for them.

BUG=367707

Review URL: https://codereview.chromium.org/274063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269572 0039d316-1c4b-4281-b951-d872f2087c98

components/bookmarks/core/browser/bookmark_client.cc

@@ -6,6 +6,10 @@
 
 #include "base/logging.h"
 
+bool BookmarkClient::PreferTouchIcon() {
+  return false;
+}
+
 base::CancelableTaskTracker::TaskId BookmarkClient::GetFaviconImageForURL(
     const GURL& page_url,
     int icon_types,

components/bookmarks/core/browser/bookmark_client.h

@@ -39,7 +39,7 @@ class BookmarkClient {
   typedef std::vector<NodeTypedCountPair> NodeTypedCountPairs;
 
   // Returns true if the embedder favors touch icons over favicons.
-  virtual bool PreferTouchIcon() = 0;
+  virtual bool PreferTouchIcon();
 
   // Requests the favicon of any of |icon_types| whose pixel sizes most
   // closely match |desired_size_in_dip| (if value is 0, the largest favicon

components/bookmarks/core/test/test_bookmark_client.cc

@@ -15,10 +15,6 @@ scoped_ptr<BookmarkModel> TestBookmarkClient::CreateModel(bool index_urls) {
   return bookmark_model.Pass();
 }
 
-bool TestBookmarkClient::PreferTouchIcon() {
-  return false;
-}
-
 void TestBookmarkClient::RecordAction(const base::UserMetricsAction& action) {
 }
 

components/bookmarks/core/test/test_bookmark_client.h

@@ -23,7 +23,6 @@ class TestBookmarkClient : public BookmarkClient {
 
  private:
   // BookmarkClient:
-  virtual bool PreferTouchIcon() OVERRIDE;
   virtual void RecordAction(const base::UserMetricsAction& action) OVERRIDE;
 
   DISALLOW_COPY_AND_ASSIGN(TestBookmarkClient);