Commit efb1f0ef authored by Lijin Shen's avatar Lijin Shen Committed by Commit Bot

Fix smallest touch size of menu button on duet

Thouch menu_button_wrapper is big enough to meet the requirement of
smallest touch size, it does not handle the click or touch events.
The image button, which is handling the click event, inside the
menu_button_wrapper is too small.

Bug: 1038691
Change-Id: If1f6bd4e0dabdc238f9f1a37604b843cb60c360e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986251Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#728630}
parent 48d98205
...@@ -19,6 +19,7 @@ ...@@ -19,6 +19,7 @@
<org.chromium.chrome.browser.toolbar.HomeButton <org.chromium.chrome.browser.toolbar.HomeButton
android:id="@+id/home_button" android:id="@+id/home_button"
app:tint="@color/standard_mode_tint" app:tint="@color/standard_mode_tint"
android:background="?attr/selectableItemBackgroundBorderless"
android:contentDescription="@string/accessibility_toolbar_btn_home" android:contentDescription="@string/accessibility_toolbar_btn_home"
style="@style/SplitToolbarButton" /> style="@style/SplitToolbarButton" />
...@@ -29,6 +30,7 @@ ...@@ -29,6 +30,7 @@
android:src="@drawable/ic_share_white_24dp" android:src="@drawable/ic_share_white_24dp"
app:tint="@color/standard_mode_tint" app:tint="@color/standard_mode_tint"
android:contentDescription="@string/share" android:contentDescription="@string/share"
android:background="?attr/selectableItemBackgroundBorderless"
style="@style/SplitToolbarButton" /> style="@style/SplitToolbarButton" />
<include layout="@layout/toolbar_space" /> <include layout="@layout/toolbar_space" />
...@@ -51,6 +53,7 @@ ...@@ -51,6 +53,7 @@
android:id="@+id/tab_switcher_button" android:id="@+id/tab_switcher_button"
style="@style/SplitToolbarButton" style="@style/SplitToolbarButton"
app:menuMaxWidth="@dimen/tab_switcher_menu_width" app:menuMaxWidth="@dimen/tab_switcher_menu_width"
android:background="?attr/selectableItemBackgroundBorderless"
android:contentDescription="@string/accessibility_toolbar_btn_tabswitcher_toggle_default" android:contentDescription="@string/accessibility_toolbar_btn_tabswitcher_toggle_default"
app:menuVerticalOverlapAnchor="false" /> app:menuVerticalOverlapAnchor="false" />
......
...@@ -15,21 +15,19 @@ ...@@ -15,21 +15,19 @@
<org.chromium.ui.widget.ChromeImageButton <org.chromium.ui.widget.ChromeImageButton
android:id="@+id/menu_button" android:id="@+id/menu_button"
android:layout_height="wrap_content" style="@style/SplitToolbarButton"
android:layout_width="wrap_content"
android:background="@null"
android:src="@drawable/ic_more_vert_24dp" android:src="@drawable/ic_more_vert_24dp"
android:importantForAccessibility="no" android:importantForAccessibility="no"
android:layout_gravity="center" android:layout_gravity="center"
android:background="?attr/selectableItemBackgroundBorderless"
app:tint="@color/standard_mode_tint" /> app:tint="@color/standard_mode_tint" />
<ImageView <ImageView
android:id="@+id/menu_badge" android:id="@+id/menu_badge"
android:layout_height="wrap_content" style="@style/SplitToolbarButton"
android:layout_width="wrap_content"
android:background="@null"
android:src="@drawable/badge_update_dark" android:src="@drawable/badge_update_dark"
tools:ignore="ContentDescription" tools:ignore="ContentDescription"
android:background="?attr/selectableItemBackgroundBorderless"
android:importantForAccessibility="no" android:importantForAccessibility="no"
android:layout_gravity="center" android:layout_gravity="center"
android:visibility="invisible" /> android:visibility="invisible" />
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment