Rename page_needs_translation to can_offer_translation
page_needs_translation() tells us if translation is allowed, not if the page needs translation. It should be renamed to page_level_translation_critiera_met. We can offer translation if the page doesn't have notranslate and the determined language isn't empty. Bug: 1152884 Change-Id: I647b17f4775787d04f34ee2076b32d53b330af55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561293 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:Colin Blundell <blundell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#832683}
Showing
Please register or sign in to comment