Commit efeb0bc2 authored by tyoshino@chromium.org's avatar tyoshino@chromium.org

[Notification] Stop calling detachPresenter().

It's empty on Blink side now. Rather than implementing it or leave it empty,
just stop calling it. In Chromium, content::NotificationProvider never goes
away.

BUG=none

Review URL: https://codereview.chromium.org/36073007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233519 0039d316-1c4b-4281-b951-d872f2087c98
parent c32e2708
...@@ -66,16 +66,6 @@ void ActiveNotificationTracker::Clear() { ...@@ -66,16 +66,6 @@ void ActiveNotificationTracker::Clear() {
} }
} }
void ActiveNotificationTracker::DetachAll() {
ReverseTable::iterator iter;
for (iter = reverse_notification_table_.begin();
iter != reverse_notification_table_.end();
++iter) {
WebNotification notification(iter->first);
notification.detachPresenter();
}
}
WebNotificationPermissionCallback* ActiveNotificationTracker::GetCallback( WebNotificationPermissionCallback* ActiveNotificationTracker::GetCallback(
int id) { int id) {
return callback_table_.Lookup(id); return callback_table_.Lookup(id);
......
...@@ -42,10 +42,6 @@ class CONTENT_EXPORT ActiveNotificationTracker { ...@@ -42,10 +42,6 @@ class CONTENT_EXPORT ActiveNotificationTracker {
// Clears out all active notifications. Useful on page navigation. // Clears out all active notifications. Useful on page navigation.
void Clear(); void Clear();
// Detaches all active notifications from their presenter. Necessary
// when the Presenter is destroyed.
void DetachAll();
private: private:
typedef std::map<blink::WebNotification, int> ReverseTable; typedef std::map<blink::WebNotification, int> ReverseTable;
......
...@@ -32,7 +32,6 @@ NotificationProvider::NotificationProvider(RenderViewImpl* render_view) ...@@ -32,7 +32,6 @@ NotificationProvider::NotificationProvider(RenderViewImpl* render_view)
} }
NotificationProvider::~NotificationProvider() { NotificationProvider::~NotificationProvider() {
manager_.DetachAll();
} }
bool NotificationProvider::show(const WebNotification& notification) { bool NotificationProvider::show(const WebNotification& notification) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment