Allow the use of arrow keys in dialogs on the login screen.

Previously, when a modal was open, the left and right arrow keys were
activating the accelerator used to toggle between users on the the
main login screen underneath.

Fixed: 1019912
Change-Id: Ibd9cde9e7239566ae75c36a388722b4a08b0a71c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930105Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718408}

ash/login/ui/lock_contents_view.cc

@@ -2125,12 +2125,21 @@ void LockContentsView::SetDisplayStyle(DisplayStyle style) {
   Layout();
 }
 
+bool LockContentsView::OnKeyPressed(const ui::KeyEvent& event) {
+  switch (event.key_code()) {
+    case ui::VKEY_RIGHT:
+      FocusNextUser();
+      return true;
+    case ui::VKEY_LEFT:
+      FocusPreviousUser();
+      return true;
+    default:
+      return false;
+  }
+}
+
 void LockContentsView::RegisterAccelerators() {
-  // Accelerators that apply on login and lock:
-  accel_map_[ui::Accelerator(ui::VKEY_RIGHT, 0)] =
-      AcceleratorAction::kFocusNextUser;
-  accel_map_[ui::Accelerator(ui::VKEY_LEFT, 0)] =
-      AcceleratorAction::kFocusPreviousUser;
+  // Applies on login and lock:
   accel_map_[ui::Accelerator(ui::VKEY_V, ui::EF_ALT_DOWN)] =
       AcceleratorAction::kShowSystemInfo;
 
@@ -2160,12 +2169,6 @@ void LockContentsView::RegisterAccelerators() {
 
 void LockContentsView::PerformAction(AcceleratorAction action) {
   switch (action) {
-    case AcceleratorAction::kFocusNextUser:
-      FocusNextUser();
-      break;
-    case AcceleratorAction::kFocusPreviousUser:
-      FocusPreviousUser();
-      break;
     case AcceleratorAction::kShowSystemInfo:
       ShowSystemInfo();
       break;

ash/login/ui/lock_contents_view.h

@@ -106,8 +106,6 @@ class ASH_EXPORT LockContentsView
   };
 
   enum class AcceleratorAction {
-    kFocusNextUser,
-    kFocusPreviousUser,
     kShowSystemInfo,
     kShowFeedback,
     kShowResetScreen,
@@ -137,6 +135,7 @@ class ASH_EXPORT LockContentsView
   void Layout() override;
   void AddedToWidget() override;
   void OnFocus() override;
+  bool OnKeyPressed(const ui::KeyEvent& event) override;
   void AboutToRequestFocusFromTabTraversal(bool reverse) override;
   void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
   bool AcceleratorPressed(const ui::Accelerator& accelerator) override;