Commit eff9809b authored by Xiaocheng Hu's avatar Xiaocheng Hu Committed by Commit Bot

DCHECK validity of |caret_offset| in AdjustInlineBoxPositionForTextDirectionInternal()

The function accepts |caret_offset| at either left or right edge of
|inline_box|. This patch adds DCHECKs to ensure it.

Bug: 822575
Change-Id: I247361097f37f0cd9922442ea8c050f88136d9fc
Reviewed-on: https://chromium-review.googlesource.com/999021Reviewed-by: default avatarYoichi Osato <yoichio@chromium.org>
Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548695}
parent 36977118
...@@ -165,6 +165,9 @@ InlineBoxPosition AdjustInlineBoxPositionForTextDirectionInternal( ...@@ -165,6 +165,9 @@ InlineBoxPosition AdjustInlineBoxPositionForTextDirectionInternal(
InlineBox* inline_box, InlineBox* inline_box,
int caret_offset, int caret_offset,
UnicodeBidi unicode_bidi) { UnicodeBidi unicode_bidi) {
DCHECK(caret_offset == inline_box->CaretLeftmostOffset() ||
caret_offset == inline_box->CaretRightmostOffset());
const TextDirection primary_direction = const TextDirection primary_direction =
inline_box->Root().Block().Style()->Direction(); inline_box->Root().Block().Style()->Direction();
if (inline_box->Direction() == primary_direction) if (inline_box->Direction() == primary_direction)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment