Commit f005ebd5 authored by Kenneth Russell's avatar Kenneth Russell Committed by Commit Bot

Switch WebGL's back buffer back to 4x MSAA from 8x MSAA.

8x MSAA caused performance regressions across a large range of GPUs
and operating systems. WebGL 2.0 applications have full control of
multisampling, and can use an 8x MSAA framebuffer if desired. Restore
4x MSAA for WebGL's back buffer.

Leave the associated driver bug workaround in place on the various
platforms, as it's passed into Skia and used there.

Bug: 1063437
Change-Id: I3bfa3905bc02794c7a503164f802b193bd9a66b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524121
Commit-Queue: Shrek Shao <shrekshao@google.com>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Auto-Submit: Kenneth Russell <kbr@chromium.org>
Reviewed-by: default avatarShrek Shao <shrekshao@google.com>
Reviewed-by: default avatarJames Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825620}
parent f6751ab2
......@@ -91,8 +91,6 @@ WebGraphicsContext3DProviderImpl::GetWebglPreferences() const {
if (gpu_feature_info.IsWorkaroundEnabled(MAX_MSAA_SAMPLE_COUNT_2))
prefs.msaa_sample_count = 2;
else if (gpu_feature_info.IsWorkaroundEnabled(MAX_MSAA_SAMPLE_COUNT_4))
prefs.msaa_sample_count = 4;
if (command_line->HasSwitch(switches::kWebglMSAASampleCount)) {
std::string sample_count =
......
......@@ -3658,6 +3658,6 @@
"features": [
"max_msaa_sample_count_4"
]
}
}
]
}
......@@ -77,7 +77,7 @@ enum AntialiasingMode {
struct WebglPreferences {
AntialiasingMode anti_aliasing_mode = kAntialiasingModeUnspecified;
uint32_t msaa_sample_count = 8;
uint32_t msaa_sample_count = 4;
uint32_t eqaa_storage_sample_count = 4;
// WebGL-specific numeric limits.
uint32_t max_active_webgl_contexts = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment