Commit f014e5bb authored by Wez's avatar Wez Committed by Commit Bot

Remove "dom_keycode_converter" from //ui/events/events_base public_deps.

Since dom_keycode_converter is a static_library(), having it be a public
dependency of a component() doesn't make sense - consumers of the
events_base target can import the headers, but they refer to symbols
that the component's dynamic library doesn't export.

Change-Id: I859764fb50324fed1d22bc0ee8335d057c73771d
Reviewed-on: https://chromium-review.googlesource.com/1107310Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568858}
parent 1178f181
......@@ -119,11 +119,11 @@ component("events_base") {
defines = [ "EVENTS_BASE_IMPLEMENTATION" ]
deps = [
":dom_keycode_converter",
"//base/third_party/dynamic_annotations",
]
public_deps = [
":dom_keycode_converter",
":event_constants",
":platform_event",
"//base",
......@@ -393,6 +393,7 @@ static_library("test_support") {
]
public_deps = [
":dom_keycode_converter",
":events",
":events_base",
":gesture_detection",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment