Commit f01c98a1 authored by Daniel Hosseinian's avatar Daniel Hosseinian Committed by Commit Bot

Remove Cloud Print 'Learn more' URL from chrome://settings

As Cloud Print is being deprecated, there should not be any entry points
for users to learn about it.

Screenshot of change: https://imgur.com/a/STglnxD

Bug: 1114349
Change-Id: Iedd159320fcc69618676d6d2cf2cdbd80385d733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343787
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796209}
parent 06c9b757
......@@ -936,9 +936,6 @@
<message name="IDS_SETTINGS_PRINTING" desc="Title of the printing page and navigation item to get there.">
Printing
</message>
<message name="IDS_SETTINGS_PRINTING_CLOUD_PRINT_LEARN_MORE_LABEL" desc="Label for the link that teaches users how to use Google Cloud Print">
Set up or manage printers in Google Cloud Print.
</message>
<message name="IDS_SETTINGS_PRINTING_NOTIFICATIONS_LABEL" desc="Label for the checkbox which enabled notifications when new printers are added to the user's network">
Show notifications when new printers are detected on the network
</message>
......
<style include="cr-shared-style settings-shared iron-flex"></style>
<div class="cr-row first">
<div class="flex cr-padded-text">
$i18n{printingCloudPrintLearnMoreLabel}
<a href="$i18n{printingCloudPrintLearnMoreUrl}" target="_blank">
$i18n{learnMore}
</a>
</div>
</div>
<settings-toggle-button
class="hr"
pref="{{prefs.local_discovery.notifications_enabled}}"
label="$i18n{printingNotificationsLabel}">
</settings-toggle-button>
......
......@@ -1193,8 +1193,6 @@ void AddPeopleStrings(content::WebUIDataSource* html_source, Profile* profile) {
void AddPrintingStrings(content::WebUIDataSource* html_source) {
static constexpr webui::LocalizedString kLocalizedStrings[] = {
{"printingPageTitle", IDS_SETTINGS_PRINTING},
{"printingCloudPrintLearnMoreLabel",
IDS_SETTINGS_PRINTING_CLOUD_PRINT_LEARN_MORE_LABEL},
{"printingNotificationsLabel", IDS_SETTINGS_PRINTING_NOTIFICATIONS_LABEL},
{"printingManageCloudPrintDevices",
IDS_SETTINGS_PRINTING_MANAGE_CLOUD_PRINT_DEVICES},
......@@ -1206,8 +1204,6 @@ void AddPrintingStrings(content::WebUIDataSource* html_source) {
AddLocalizedStringsBulk(html_source, kLocalizedStrings);
html_source->AddString("devicesUrl", chrome::kChromeUIDevicesURL);
html_source->AddString("printingCloudPrintLearnMoreUrl",
chrome::kCloudPrintLearnMoreURL);
}
void AddPrivacyStrings(content::WebUIDataSource* html_source,
......
......@@ -98,13 +98,6 @@ const char kChromeUIUntrustedNewTabPageUrl[] =
const char kChromiumProjectURL[] = "https://www.chromium.org/";
const char kCloudPrintLearnMoreURL[] =
#if defined(OS_CHROMEOS)
"https://support.google.com/chromebook/?p=settings_cloud_print";
#else
"https://support.google.com/chrome/?p=settings_cloud_print";
#endif
const char kCloudPrintCertificateErrorLearnMoreURL[] =
#if defined(OS_CHROMEOS)
"https://support.google.com/chromebook?p=cloudprint_error_troubleshoot";
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment