Set default value for domain on offline sign-in screen

Polymer v2 evaluates i18nDynamic(as it has defined locale param),
but does not evaluate !domain as only one undefined param.

Fixed: 1059735
Change-Id: Ia8ac3a166590e669d77760f1bdd0c1786712c6f7
Bug: 1059735
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095009
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#748281}

chrome/browser/chromeos/login/login_browsertest.cc

@@ -17,6 +17,7 @@
 #include "chrome/browser/chromeos/login/test/guest_session_mixin.h"
 #include "chrome/browser/chromeos/login/test/login_manager_mixin.h"
 #include "chrome/browser/chromeos/login/test/offline_gaia_test_mixin.h"
+#include "chrome/browser/chromeos/login/test/session_manager_state_waiter.h"
 #include "chrome/browser/chromeos/login/ui/login_display_host_webui.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/common/chrome_constants.h"
@@ -172,10 +173,13 @@ IN_PROC_BROWSER_TEST_F(LoginTest, PRE_GaiaAuthOffline) {
   offline_gaia_test_mixin_.PrepareOfflineGaiaLogin();
 }
 
-// Flaking: https://crbug.com/1023591
 IN_PROC_BROWSER_TEST_F(LoginTest, GaiaAuthOffline) {
   offline_gaia_test_mixin_.GoOffline();
-  offline_gaia_test_mixin_.SignIn(test_user_.account_id, kPassword);
+  offline_gaia_test_mixin_.InitOfflineLogin(test_user_.account_id, kPassword);
+  offline_gaia_test_mixin_.CheckManagedStatus(false);
+  offline_gaia_test_mixin_.SubmitGaiaAuthOfflineForm(
+      test_user_.account_id.GetUserEmail(), kPassword,
+      true /* wait for sign-in */);
   TestSystemTrayIsVisible(false);
 }
 

chrome/browser/chromeos/login/test/offline_gaia_test_mixin.cc

@@ -68,14 +68,14 @@ void OfflineGaiaTestMixin::GoOnline() {
   network_state_test_helper_.reset();
 }
 
-void OfflineGaiaTestMixin::SignIn(const AccountId& test_account_id,
-                                  const std::string& password) {
-  ASSERT_TRUE((test_account_id.HasAccountIdKey()));
-
-  InitOfflineLogin(test_account_id, password);
-  SubmitGaiaAuthOfflineForm(test_account_id.GetUserEmail(), password);
-  SessionStateWaiter(session_manager::SessionState::LOGGED_IN_NOT_ACTIVE)
-      .Wait();
+void OfflineGaiaTestMixin::CheckManagedStatus(bool expected_is_managed) {
+  if (expected_is_managed) {
+    test::OobeJS().ExpectVisiblePath(
+        {"gaia-signin", "offline-gaia", "managedBy"});
+  } else {
+    test::OobeJS().ExpectHiddenPath(
+        {"gaia-signin", "offline-gaia", "managedBy"});
+  }
 }
 
 void OfflineGaiaTestMixin::InitOfflineLogin(const AccountId& test_account_id,
@@ -102,7 +102,8 @@ void OfflineGaiaTestMixin::StartGaiaAuthOffline() {
 
 void OfflineGaiaTestMixin::SubmitGaiaAuthOfflineForm(
     const std::string& user_email,
-    const std::string& password) {
+    const std::string& password,
+    bool wait_for_signin) {
   test::OobeJS().ExpectVisiblePath({"gaia-signin", "offline-gaia"});
   test::OobeJS().ExpectHiddenPath({"gaia-signin", "signin-frame-dialog"});
   test::OobeJS()
@@ -129,6 +130,10 @@ void OfflineGaiaTestMixin::SubmitGaiaAuthOfflineForm(
                               {"gaia-signin", "offline-gaia", "passwordInput"});
   test::OobeJS().ClickOnPath(
       {"gaia-signin", "offline-gaia", "next-button"});
+  if (wait_for_signin) {
+    SessionStateWaiter(session_manager::SessionState::LOGGED_IN_NOT_ACTIVE)
+        .Wait();
+  }
 }
 
 }  // namespace chromeos

chrome/browser/chromeos/login/test/offline_gaia_test_mixin.h

@@ -34,22 +34,24 @@ class OfflineGaiaTestMixin : public InProcessBrowserTestMixin {
   void GoOffline();
   void GoOnline();
 
-  // Loads offline GAIA page and signs-in.
-  // Expects user to be already registered (probably via LoginManagerMixin).
-  // Expects networking to be disabled (probably by caling GoOffline())
-  void SignIn(const AccountId& test_account_id, const std::string& password);
+  // Checks if UI displays management notification.
+  void CheckManagedStatus(bool expected_is_managed);
 
- private:
   // Initializes UserManager for offline Login.
+  // Expects networking to be disabled (probably by calling GoOffline())
   void InitOfflineLogin(const AccountId& test_account_id,
                         const std::string& password);
 
-  // Triggers Offlige Gaia screen.
-  void StartGaiaAuthOffline();
-
   // Fills in and submits offline GAIA login.
+  // Expects user to be already registered (probably via LoginManagerMixin).
+  // Optionally waits for sign-in to complete.
   void SubmitGaiaAuthOfflineForm(const std::string& user_email,
-                                 const std::string& password);
+                                 const std::string& password,
+                                 bool wait_for_signin);
+
+ private:
+  // Triggers Offlige Gaia screen.
+  void StartGaiaAuthOffline();
 
   // This is ised to disable networking.
   std::unique_ptr<chromeos::NetworkStateTestHelper> network_state_test_helper_;

chrome/browser/resources/chromeos/login/offline_gaia.js

@@ -21,6 +21,7 @@
 
       domain: {
         type: String,
+        value: null,
       },
 
       emailDomain: String,