VR: Remove VR keyboard flag

This flag has defaulted on for more than one release, and is no longer
needed.

BUG=
R=ymalik

Change-Id: I93f8aadb1e2cb78a558a7bdc5030fdf30d1dcff9
Reviewed-on: https://chromium-review.googlesource.com/1014350Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551321}

chrome/browser/about_flags.cc

@@ -2236,9 +2236,6 @@ const FeatureEntry kFeatureEntries[] = {
      FEATURE_WITH_PARAMS_VALUE_TYPE(features::kWebXrRenderPath,
                                     kWebXrRenderPathVariations,
                                     "WebXrRenderPath")},
-    {"vr-browser-keyboard", flag_descriptions::kVrBrowserKeyboardName,
-     flag_descriptions::kVrBrowserKeyboardDescription, kOsAndroid,
-     FEATURE_VALUE_TYPE(features::kVrBrowserKeyboard)},
     {"vr-web-input-editing", flag_descriptions::kVrWebInputEditingName,
      flag_descriptions::kVrWebInputEditingDescription, kOsAndroid,
      FEATURE_VALUE_TYPE(features::kVrWebInputEditing)},

chrome/browser/android/vr/vr_gl_thread.cc

@@ -56,7 +56,6 @@ void VrGLThread::SetInputConnection(VrInputConnection* input_connection) {
 
 void VrGLThread::Init() {
   bool keyboard_enabled =
-      base::FeatureList::IsEnabled(features::kVrBrowserKeyboard) &&
       !ui_initial_state_.web_vr_autopresentation_expected;
   if (keyboard_enabled) {
     keyboard_delegate_ = GvrKeyboardDelegate::Create();

chrome/browser/flag_descriptions.cc

@@ -2976,10 +2976,6 @@ const char kWebVrVsyncAlignDescription[] =
 
 #if defined(OS_ANDROID)
 
-const char kVrBrowserKeyboardName[] = "Chrome VR virtual keyboard.";
-const char kVrBrowserKeyboardDescription[] =
-    "Enable a virtual keyboard for Chrome VR.";
-
 const char kVrWebInputEditingName[] = "VR browsing web input editing";
 const char kVrWebInputEditingDescription[] =
     "Allow editing web input fields while in VR mode.";

chrome/browser/flag_descriptions.h

@@ -1825,9 +1825,6 @@ extern const char kWebVrVsyncAlignDescription[];
 
 #if defined(OS_ANDROID)
 
-extern const char kVrBrowserKeyboardName[];
-extern const char kVrBrowserKeyboardDescription[];
-
 extern const char kVrWebInputEditingName[];
 extern const char kVrWebInputEditingDescription[];
 

chrome/browser/vr/ui_scene_creator.cc

@@ -2048,20 +2048,15 @@ void UiSceneCreator::CreateUrlBar() {
                 &Rect::SetColor);
   scene_->AddUiElement(kUrlBarLayout, std::move(separator));
 
-  base::RepeatingCallback<void()> url_click_callback;
-  if (base::FeatureList::IsEnabled(features::kVrBrowserKeyboard)) {
-    url_click_callback = base::BindRepeating(
-        [](Model* model, UiBrowserInterface* browser) {
-          if (model->needs_keyboard_update) {
-            browser->OnUnsupportedMode(UiUnsupportedMode::kNeedsKeyboardUpdate);
-          } else {
-            model->push_mode(kModeEditingOmnibox);
-          }
-        },
-        base::Unretained(model_), base::Unretained(browser_));
-  } else {
-    url_click_callback = base::BindRepeating([] {});
-  }
+  auto url_click_callback = base::BindRepeating(
+      [](Model* model, UiBrowserInterface* browser) {
+        if (model->needs_keyboard_update) {
+          browser->OnUnsupportedMode(UiUnsupportedMode::kNeedsKeyboardUpdate);
+        } else {
+          model->push_mode(kModeEditingOmnibox);
+        }
+      },
+      base::Unretained(model_), base::Unretained(browser_));
 
   auto origin_region = Create<Button>(kUrlBarOriginRegion, kPhaseForeground,
                                       url_click_callback, audio_delegate_);

chrome/common/chrome_features.cc

@@ -252,10 +252,6 @@ const base::Feature kExperimentalKeyboardLockUI{
     "ExperimentalKeyboardLockUI", base::FEATURE_DISABLED_BY_DEFAULT};
 
 #if BUILDFLAG(ENABLE_VR)
-// Enables the virtual keyboard for Chrome VR.
-const base::Feature kVrBrowserKeyboard{"VrBrowserKeyboard",
-                                       base::FEATURE_ENABLED_BY_DEFAULT};
-
 // Controls features related to VR browsing that are under development.
 const base::Feature kVrBrowsingExperimentalFeatures{
     "VrBrowsingExperimentalFeatures", base::FEATURE_DISABLED_BY_DEFAULT};

chrome/common/chrome_features.h

@@ -139,7 +139,6 @@ extern const base::Feature kExperimentalKeyboardLockUI;
 extern const base::Feature kVrBrowsing;
 #endif
 #if BUILDFLAG(ENABLE_VR)
-extern const base::Feature kVrBrowserKeyboard;
 extern const base::Feature kVrBrowsingExperimentalFeatures;
 extern const base::Feature kVrBrowsingExperimentalRendering;