Commit f04dc2b3 authored by David Dorwin's avatar David Dorwin Committed by Commit Bot

[fuchsia] Reduce severity of unexpected arg log statement

This log statement can occur when adding/removing supported arguments,
so reduce it to a WARNING and provide context.

Bug: 1032439

Change-Id: I500c5ff5d64268b1557da18724ad9c061c216936
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261066Reviewed-by: default avatarWez <wez@chromium.org>
Reviewed-by: default avatarKevin Marshall <kmarshall@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782122}
parent 2649e514
......@@ -180,9 +180,10 @@ bool MaybeAddCommandLineArgsFromConfig(const base::Value& config,
for (const auto& arg : args->DictItems()) {
if (!base::Contains(kAllowedArgs, arg.first)) {
LOG(ERROR) << "Unknown command-line arg: " << arg.first;
// TODO(https://crbug.com/1032439): Return false here once we are done
// experimenting with memory-related command-line options.
// TODO(https://crbug.com/1032439): Increase severity and return false
// once we have a mechanism for soft transitions of supported arguments.
LOG(WARNING) << "Unknown command-line arg: '" << arg.first
<< "'. Config file and WebEngine version may not match.";
continue;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment