Commit f0543f54 authored by Miyoung Shin's avatar Miyoung Shin Committed by Commit Bot

Clean up a binder registry in DedicatedWorkerHost

This CL cleans up the binder registry in DedicatedWorkerHost
class since WebUsbService mojom interface has been bound via
BrowserInterfaceBroker by https://crrev.com/c/1768839, and
nothing registers a mojo interface to the binder registry.

Bug: 936482
Change-Id: I3c533da40e4c5d7bf03a36ff16185c2cb7a6062c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941652
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719934}
parent 8bbd4d70
......@@ -48,7 +48,6 @@ DedicatedWorkerHost::DedicatedWorkerHost(
origin_(origin),
host_receiver_(this, std::move(host)) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
RegisterMojoInterfaces();
}
DedicatedWorkerHost::~DedicatedWorkerHost() = default;
......@@ -61,11 +60,6 @@ void DedicatedWorkerHost::GetInterface(
if (!worker_process_host)
return;
// See if the registry that is specific to this worker host wants to handle
// the interface request.
if (registry_.TryBindInterface(interface_name, &interface_pipe))
return;
BindWorkerInterface(interface_name, std::move(interface_pipe),
worker_process_host, origin_);
}
......@@ -225,12 +219,6 @@ void DedicatedWorkerHost::StartScriptLoad(
weak_factory_.GetWeakPtr()));
}
void DedicatedWorkerHost::RegisterMojoInterfaces() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
registry_.AddInterface(base::BindRepeating(
&DedicatedWorkerHost::CreateWebUsbService, base::Unretained(this)));
}
void DedicatedWorkerHost::DidStartScriptLoad(
std::unique_ptr<blink::URLLoaderFactoryBundleInfo>
subresource_loader_factories,
......
......@@ -13,7 +13,6 @@
#include "mojo/public/cpp/bindings/pending_remote.h"
#include "mojo/public/cpp/bindings/receiver.h"
#include "mojo/public/cpp/bindings/remote.h"
#include "services/service_manager/public/cpp/binder_registry.h"
#include "services/service_manager/public/mojom/interface_provider.mojom.h"
#include "third_party/blink/public/mojom/filesystem/file_system.mojom-forward.h"
#include "third_party/blink/public/mojom/idle/idle_manager.mojom-forward.h"
......@@ -114,8 +113,6 @@ class DedicatedWorkerHost final
mojo::Remote<blink::mojom::DedicatedWorkerHostFactoryClient> client);
private:
void RegisterMojoInterfaces();
// Called from WorkerScriptFetchInitiator. Continues starting the dedicated
// worker in the renderer process.
//
......@@ -181,8 +178,6 @@ class DedicatedWorkerHost final
std::unique_ptr<ServiceWorkerNavigationHandle> service_worker_handle_;
service_manager::BinderRegistry registry_;
BrowserInterfaceBrokerImpl<DedicatedWorkerHost, const url::Origin&> broker_{
this};
mojo::Receiver<blink::mojom::BrowserInterfaceBroker> broker_receiver_{
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment