Commit f0555a5e authored by tommycli's avatar tommycli Committed by Commit bot

Plugin Power Saver: Fix PDF interaction with Enterprise ASK policy.

Currently, on users with the ASK enterprise policy, viewing PDFs requires
two right-click acknowledgements. This is broken.

BUG=484247

Review URL: https://codereview.chromium.org/1137073006

Cr-Commit-Position: refs/heads/master@{#329640}
parent 80975779
...@@ -377,6 +377,7 @@ void PluginInfoMessageFilter::Context::DecidePluginStatus( ...@@ -377,6 +377,7 @@ void PluginInfoMessageFilter::Context::DecidePluginStatus(
plugin_metadata->identifier(), &plugin_setting, plugin_metadata->identifier(), &plugin_setting,
&uses_default_content_setting, &is_managed); &uses_default_content_setting, &is_managed);
// TODO(tommycli): Remove once we deprecate the plugin ASK policy.
bool legacy_ask_user = plugin_setting == CONTENT_SETTING_ASK; bool legacy_ask_user = plugin_setting == CONTENT_SETTING_ASK;
plugin_setting = content_settings::PluginsFieldTrial::EffectiveContentSetting( plugin_setting = content_settings::PluginsFieldTrial::EffectiveContentSetting(
CONTENT_SETTINGS_TYPE_PLUGINS, plugin_setting); CONTENT_SETTINGS_TYPE_PLUGINS, plugin_setting);
...@@ -568,8 +569,13 @@ void PluginInfoMessageFilter::Context::GetPluginContentSetting( ...@@ -568,8 +569,13 @@ void PluginInfoMessageFilter::Context::GetPluginContentSetting(
// If there is a plugin-specific setting, we use it, unless the general // If there is a plugin-specific setting, we use it, unless the general
// setting was set by policy, in which case it takes precedence. // setting was set by policy, in which case it takes precedence.
uses_plugin_specific_setting = specific_setting && // TODO(tommycli): Remove once we deprecate the plugin ASK policy.
(general_info.source != content_settings::SETTING_SOURCE_POLICY); bool legacy_ask_user = content_settings::ValueToContentSetting(
general_setting.get()) == CONTENT_SETTING_ASK;
bool use_policy =
general_info.source == content_settings::SETTING_SOURCE_POLICY &&
!legacy_ask_user;
uses_plugin_specific_setting = specific_setting && !use_policy;
if (uses_plugin_specific_setting) { if (uses_plugin_specific_setting) {
value = specific_setting.Pass(); value = specific_setting.Pass();
info = specific_info; info = specific_info;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment