Commit f059e094 authored by Roman Arora's avatar Roman Arora Committed by Josip Sokcevic

Tab Search: Close button hover and focus states UX audit

Screenshots

Hover:
https://drive.google.com/file/d/1xxvmhVfUMVn6gKTC5N2nNL9HrvyaPzKK/view

Focus:
https://drive.google.com/file/d/1AQoUfTUeKRyPhmlmb5CdnQLrvBFyQuZc/view

Bug: 1128599
Change-Id: Ia856b9e25b006fd5710ce2af8ca08ae7e2596740
Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3303965Reviewed-by: default avatarJohn Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819627}
parent cce1633c
...@@ -15,6 +15,21 @@ ...@@ -15,6 +15,21 @@
.button-container cr-icon-button { .button-container cr-icon-button {
--cr-icon-button-fill-color: transparent; --cr-icon-button-fill-color: transparent;
border-radius: 50%;
}
.button-container cr-icon-button:hover {
background-color: rgba(var(--google-grey-900-rgb), 0.1);
}
@media (prefers-color-scheme: dark) {
.button-container cr-icon-button:hover {
background-color: rgba(var(--white-rgb), 0.1);
}
}
.button-container cr-icon-button:focus {
border: 2px solid rgba(var(--google-blue-600-rgb), 0.4);
} }
.favicon { .favicon {
...@@ -68,6 +83,7 @@ ...@@ -68,6 +83,7 @@
</div> </div>
<div class="button-container"> <div class="button-container">
<cr-icon-button id="closeButton" aria-label="[[ariaLabel_(data.title)]]" <cr-icon-button id="closeButton" aria-label="[[ariaLabel_(data.title)]]"
iron-icon="mwb16:close" on-click="onItemClose_" title="$i18n{closeTab}"> disable-ripple iron-icon="mwb16:close" on-click="onItemClose_"
title="$i18n{closeTab}">
</cr-icon-button> </cr-icon-button>
</div> </div>
...@@ -5,6 +5,10 @@ ...@@ -5,6 +5,10 @@
<title>Tab Search</title> <title>Tab Search</title>
<link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css"> <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">
<style> <style>
html {
--white-rgb: 255, 255, 255;
}
html, html,
body { body {
width: 320px; width: 320px;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment