Commit f06136e7 authored by James Cook's avatar James Cook Committed by Commit Bot

Disable SyncConsentSplitSettingsSyncTest on ASAN/LSAN

There's a flaky use-after-free that seems to be related to a tabbed
browser launching in the middle of an OOBE test.

TBR=rsorokin@chromium.org

Bug: 1054377
Change-Id: Id734556588c3a6f421714e5b0c445e657f875d56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067663Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743340}
parent 0bc5f344
......@@ -303,7 +303,13 @@ class SyncConsentSplitSettingsSyncTest : public SyncConsentTest {
base::test::ScopedFeatureList sync_feature_list_;
};
IN_PROC_BROWSER_TEST_F(SyncConsentSplitSettingsSyncTest, DefaultFlow) {
// Flaky failures on sanitizer builds. https://crbug.com/1054377
#if defined(ADDRESS_SANITIZER) || defined(LEAK_SANITIZER)
#define MAYBE_DefaultFlow DISABLED_DefaultFlow
#else
#define MAYBE_DefaultFlow DefaultFlow
#endif
IN_PROC_BROWSER_TEST_F(SyncConsentSplitSettingsSyncTest, MAYBE_DefaultFlow) {
LoginToSyncConsentScreen();
// OS sync is disabled by default.
......@@ -352,7 +358,13 @@ IN_PROC_BROWSER_TEST_F(SyncConsentSplitSettingsSyncTest, DefaultFlow) {
EXPECT_TRUE(prefs->GetBoolean(syncer::prefs::kOsSyncFeatureEnabled));
}
IN_PROC_BROWSER_TEST_F(SyncConsentSplitSettingsSyncTest, UserCanDisable) {
// Flaky failures on sanitizer builds. https://crbug.com/1054377
#if defined(ADDRESS_SANITIZER) || defined(LEAK_SANITIZER)
#define MAYBE_UserCanDisable DISABLED_UserCanDisable
#else
#define MAYBE_UserCanDisable UserCanDisable
#endif
IN_PROC_BROWSER_TEST_F(SyncConsentSplitSettingsSyncTest, MAYBE_UserCanDisable) {
LoginToSyncConsentScreen();
// Wait for content to load.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment