Commit f061fb15 authored by Darin Fisher's avatar Darin Fisher Committed by Commit Bot

Clarify code guidelines

Change-Id: I06a780bb0f4964601d64ceb27330a6e5fc27de67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919737Reviewed-by: default avatarEmily Stark <estark@chromium.org>
Commit-Queue: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715921}
parent 07fa2ab5
...@@ -287,11 +287,13 @@ be used in emergencies because it will bypass all the safety nets. ...@@ -287,11 +287,13 @@ be used in emergencies because it will bypass all the safety nets.
In addition to the adhering to the [styleguide][cr-styleguide], the following In addition to the adhering to the [styleguide][cr-styleguide], the following
general rules of thumb can be helpful in navigating how to structure changes: general rules of thumb can be helpful in navigating how to structure changes:
- **Code in the Chromium project should be in service of code in the Chromium - **Code in the Chromium project should be in service of other code in the
project.** This is important so developers can understand the constraints Chromium project.** This is important so developers can understand the
informing a design decision. Those constraints should be apparent from the constraints informing a design decision. Those constraints should be apparent
scope of code within the boundary of the project and its various from the scope of code within the boundary of the project and its various
repositories. repositories. In other words, for each line of code, you should be able to
find a product in the Chromium repositories that depends on that line of code
or else the line of code should be removed.
- **Code should only be moved to a central location (e.g., //base) when - **Code should only be moved to a central location (e.g., //base) when
multiple consumers would benefit.** We should resist the temptation to multiple consumers would benefit.** We should resist the temptation to
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment