Commit f06dc2cb authored by wutao's avatar wutao Committed by Commit Bot

ambient: Fix topic source row height

The row height should be 64px for two lines Settings.

Bug: b/166807600
Test: new js test
Change-Id: I7a06e51b4d921e55457a5ffbe35964c888c1c979
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399767Reviewed-by: default avatarJimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806010}
parent 77613e2e
......@@ -18,7 +18,7 @@
topic-source-item {
align-items: center;
height: 48px;
height: 64px;
}
iron-list > *:not(:first-of-type) {
......
......@@ -147,6 +147,16 @@ suite('AmbientModeHandler', function() {
assertEquals(2, topicSourceItems.length);
});
test('topicSourceItemHasCorrectRowHeight', function() {
const topicSourceListElement = ambientModePage.$$('topic-source-list');
const ironList = topicSourceListElement.$$('iron-list');
const topicSourceItems = ironList.querySelectorAll('topic-source-item');
topicSourceItems.forEach((row) => {
assertEquals(64, row.offsetHeight);
});
});
test('Deep link to topic sources', async () => {
loadTimeData.overrideValues({isDeepLinkingEnabled: true});
assertTrue(loadTimeData.getBoolean('isDeepLinkingEnabled'));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment