Commit f06e358b authored by Sebastien Lalancette's avatar Sebastien Lalancette Committed by Commit Bot

[iOS] Adding an Unknown LinkGenerationError Value

This value will be mainly used when facing parsing failures when
converting responses from the text-fragments-polyfill JavaScript
library used on iOS.

Bug: 1136043
Change-Id: I2af25b336944a5ac4f7258de75aeec8f73b46ef4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499084Reviewed-by: default avatarsebsg <sebsg@chromium.org>
Reviewed-by: default avatarDavid Bokan <bokan@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820907}
parent aa3e29e5
...@@ -21,11 +21,14 @@ enum class LinkGenerationError { ...@@ -21,11 +21,14 @@ enum class LinkGenerationError {
kEmptySelection = 5, kEmptySelection = 5,
// Android specific. // Android specific.
kTabHidden = 5, kTabHidden = 6,
kOmniboxNavigation = 6, kOmniboxNavigation = 7,
kTabCrash = 7, kTabCrash = 8,
kMaxValue = kTabCrash // Catch-all bucket.
kUnknown = 9,
kMaxValue = kUnknown
}; };
// These values are persisted to logs. Entries should not be renumbered and // These values are persisted to logs. Entries should not be renumbered and
......
...@@ -46,7 +46,9 @@ class CORE_EXPORT TextFragmentSelectorGenerator final ...@@ -46,7 +46,9 @@ class CORE_EXPORT TextFragmentSelectorGenerator final
kOmniboxNavigation, kOmniboxNavigation,
kTabCrash, kTabCrash,
kMaxValue = kTabCrash kUnknown,
kMaxValue = kUnknown
}; };
explicit TextFragmentSelectorGenerator() = default; explicit TextFragmentSelectorGenerator() = default;
......
...@@ -40843,6 +40843,7 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> ...@@ -40843,6 +40843,7 @@ Called by update_gpu_driver_bug_workaround_entries.py.-->
<int value="6" label="Tab hidden"/> <int value="6" label="Tab hidden"/>
<int value="7" label="Omnibox navigation"/> <int value="7" label="Omnibox navigation"/>
<int value="8" label="Tab crash"/> <int value="8" label="Tab crash"/>
<int value="9" label="Unknown"/>
</enum> </enum>
<enum name="LinkMonitorFailureType"> <enum name="LinkMonitorFailureType">
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment