Remove APP_INSTALL_EVENT destination

APP_INSTALL_EVENT will roll into UPLOAD_EVENT. No need for the division.

Bug: chromium:1078512
Change-Id: I2ce795e59dbf3a255b89dd4a4b3ae5172f78ede5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436328
Commit-Queue: Zach Trudo <zatrudo@google.com>
Reviewed-by: Leonid Baraz <lbaraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817145}

chrome/browser/policy/messaging_layer/upload/app_install_report_handler.cc

@@ -162,7 +162,7 @@ Status AppInstallReportHandler::HandleRecord(Record record) {
 }
 
 Status AppInstallReportHandler::ValidateRecord(const Record& record) const {
-  return ValidateDestination(record, Destination::APP_INSTALL_EVENT);
+  return ValidateDestination(record, Destination::UPLOAD_EVENTS);
 }
 
 Status AppInstallReportHandler::ValidateDestination(

chrome/browser/policy/messaging_layer/upload/app_install_report_handler_unittest.cc

@@ -85,7 +85,7 @@ class TestRecord : public Record {
     base::JSONWriter::Write(data_, &json_data);
 
     set_data(json_data);
-    set_destination(Destination::APP_INSTALL_EVENT);
+    set_destination(Destination::UPLOAD_EVENTS);
   }
 
   const base::Value* data() const { return &data_; }
@@ -116,7 +116,7 @@ TEST_F(AppInstallReportHandlerTest, DeniesInvalidDestination) {
   AppInstallReportHandler handler(&client_);
 
   TestRecord test_record;
-  test_record.set_destination(Destination::UPLOAD_EVENTS);
+  test_record.set_destination(Destination::MEET_DEVICE_TELEMETRY);
 
   Status handle_status = handler.HandleRecord(test_record);
   EXPECT_FALSE(handle_status.ok());

chrome/browser/policy/messaging_layer/upload/upload_client_unittest.cc

@@ -176,7 +176,7 @@ TEST_F(UploadClientTest, CreateUploadClient) {
   WrappedRecord wrapped_record;
   Record* record = wrapped_record.mutable_record();
   record->set_data(json_data);
-  record->set_destination(Destination::APP_INSTALL_EVENT);
+  record->set_destination(Destination::UPLOAD_EVENTS);
 
   std::string serialized_record;
   wrapped_record.SerializeToString(&serialized_record);

components/policy/proto/record_constants.proto

@@ -15,13 +15,9 @@ enum Destination {
   // |UPLOAD_EVENTS| handler sends records to the Eventing pipeline.
   UPLOAD_EVENTS = 1;
 
-  // |APP_INSTALL_EVENT| for sending events to the DmServer for the
-  // APP_INSTALL_EVENT pipeline.
-  APP_INSTALL_EVENT = 2;
-
   // |MEET_DEVICE_TELEMETRY| handler is for telemetry data sent by Meet
   // Devices. For more information, see go/reliable-meet-device-telemetry.
-  MEET_DEVICE_TELEMETRY = 3;
+  MEET_DEVICE_TELEMETRY = 2;
 }
 
 // |Priority| is used to determine when items from the queue should be rate