[Background Fetch] total-download-exceeded -> download-total-exceeded

Update BackgroundFetchRegistration idl file to include the new changes
in the spec.

Bug: 913867
Change-Id: Ie94bc1a064734021e5bd98541d9ab47a4006aaf4
Reviewed-on: https://chromium-review.googlesource.com/c/1371387Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615584}

chrome/browser/background_fetch/background_fetch_delegate_impl.cc

@@ -532,9 +532,9 @@ void BackgroundFetchDelegateImpl::FailFetch(const std::string& job_unique_id) {
   Abort(job_unique_id);
 
   if (auto client = GetClient(unique_id)) {
-    client->OnJobCancelled(unique_id,
-                           blink::mojom::BackgroundFetchFailureReason::
-                               TOTAL_DOWNLOAD_SIZE_EXCEEDED);
+    client->OnJobCancelled(
+        unique_id,
+        blink::mojom::BackgroundFetchFailureReason::DOWNLOAD_TOTAL_EXCEEDED);
   }
 }
 

content/browser/background_fetch/background_fetch.proto

@@ -28,7 +28,7 @@ message BackgroundFetchRegistration {
     FETCH_ERROR = 4;
     SERVICE_WORKER_UNAVAILABLE = 5;
     QUOTA_EXCEEDED = 6;
-    TOTAL_DOWNLOAD_SIZE_EXCEEDED = 7;
+    DOWNLOAD_TOTAL_EXCEEDED = 7;
   }
 
   // See definition of |unique_id| in BackgroundFetchRegistrationId.

content/browser/background_fetch/background_fetch_delegate_proxy.cc

@@ -431,10 +431,11 @@ void BackgroundFetchDelegateProxy::OnJobCancelled(
     const std::string& job_unique_id,
     blink::mojom::BackgroundFetchFailureReason reason_to_abort) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
-  DCHECK(reason_to_abort ==
-             blink::mojom::BackgroundFetchFailureReason::CANCELLED_FROM_UI ||
-         reason_to_abort == blink::mojom::BackgroundFetchFailureReason::
-                                TOTAL_DOWNLOAD_SIZE_EXCEEDED);
+  DCHECK(
+      reason_to_abort ==
+          blink::mojom::BackgroundFetchFailureReason::CANCELLED_FROM_UI ||
+      reason_to_abort ==
+          blink::mojom::BackgroundFetchFailureReason::DOWNLOAD_TOTAL_EXCEEDED);
 
   // TODO(delphick): The controller may not exist as persistence is not yet
   // implemented.

content/browser/background_fetch/background_fetch_event_dispatcher.cc

@@ -99,8 +99,7 @@ void BackgroundFetchEventDispatcher::DispatchBackgroundFetchCompletionEvent(
     case blink::mojom::BackgroundFetchFailureReason::FETCH_ERROR:
     case blink::mojom::BackgroundFetchFailureReason::SERVICE_WORKER_UNAVAILABLE:
     case blink::mojom::BackgroundFetchFailureReason::QUOTA_EXCEEDED:
-    case blink::mojom::BackgroundFetchFailureReason::
-        TOTAL_DOWNLOAD_SIZE_EXCEEDED:
+    case blink::mojom::BackgroundFetchFailureReason::DOWNLOAD_TOTAL_EXCEEDED:
       DCHECK_EQ(registration->result,
                 blink::mojom::BackgroundFetchResult::FAILURE);
       DispatchBackgroundFetchFailEvent(registration_id, std::move(registration),

content/browser/background_fetch/storage/database_helpers.cc

@@ -145,9 +145,9 @@ bool MojoFailureReasonFromRegistrationProto(
       *failure_reason =
           blink::mojom::BackgroundFetchFailureReason::QUOTA_EXCEEDED;
       return true;
-    case proto::BackgroundFetchRegistration::TOTAL_DOWNLOAD_SIZE_EXCEEDED:
-      *failure_reason = blink::mojom::BackgroundFetchFailureReason::
-          TOTAL_DOWNLOAD_SIZE_EXCEEDED;
+    case proto::BackgroundFetchRegistration::DOWNLOAD_TOTAL_EXCEEDED:
+      *failure_reason =
+          blink::mojom::BackgroundFetchFailureReason::DOWNLOAD_TOTAL_EXCEEDED;
       return true;
     case proto::BackgroundFetchRegistration::FETCH_ERROR:
       *failure_reason = blink::mojom::BackgroundFetchFailureReason::FETCH_ERROR;

third_party/blink/public/platform/modules/background_fetch/background_fetch.mojom

@@ -55,8 +55,8 @@ enum BackgroundFetchFailureReason {
   // "quota-exceeded":
   QUOTA_EXCEEDED = 6,
 
-  // "total-download-exceeded":
-  TOTAL_DOWNLOAD_SIZE_EXCEEDED = 7,
+  // "download-total-exceeded":
+  DOWNLOAD_TOTAL_EXCEEDED = 7,
 };
 
 // Represents the optional options a developer can provide when starting a new

third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc

@@ -351,8 +351,8 @@ const String BackgroundFetchRegistration::failureReason() const {
       return "fetch-error";
     case mojom::BackgroundFetchFailureReason::QUOTA_EXCEEDED:
       return "quota-exceeded";
-    case mojom::BackgroundFetchFailureReason::TOTAL_DOWNLOAD_SIZE_EXCEEDED:
-      return "total-download-exceeded";
+    case mojom::BackgroundFetchFailureReason::DOWNLOAD_TOTAL_EXCEEDED:
+      return "download-total-exceeded";
   }
   NOTREACHED();
 }

third_party/blink/renderer/modules/background_fetch/background_fetch_registration.idl

@@ -3,23 +3,6 @@
 // found in the LICENSE file.
 
 // https://wicg.github.io/background-fetch/#background-fetch-registration
-enum BackgroundFetchFailureReason {
-  "",
-  // The operation was aborted by the user, or abort() was called.
-  "aborted",
-  // A response had a not-ok-status.
-  "bad-status",
-  // A fetch failed for other reasons, e.g. CORS, MIX, an invalid partial response,
-  // or a general network failure for a fetch that cannot be retried.
-  "fetch-error",
-  // Storage quota was reached during the operation.
-  "quota-exceeded",
-  // The provided downloadTotal was exceeded.
-  "total-download-exceeded"
-};
-
-enum BackgroundFetchResult { "", "success", "failure" };
-
 [
     Exposed=(Window,Worker),
     OriginTrialEnabled=BackgroundFetch
@@ -42,3 +25,22 @@ enum BackgroundFetchResult { "", "success", "failure" };
     [CallWith=ScriptState, Exposed=ServiceWorker, RaisesException, MeasureAs=BackgroundFetchRegistrationMatch] Promise<BackgroundFetchRecord> match(RequestInfo request, optional CacheQueryOptions options);
     [CallWith=ScriptState, Exposed=ServiceWorker, RaisesException, MeasureAs=BackgroundFetchRegistrationMatchAll] Promise<sequence<BackgroundFetchRecord>> matchAll(optional RequestInfo request, optional CacheQueryOptions options);
 };
+
+enum BackgroundFetchResult { "", "success", "failure" };
+
+enum BackgroundFetchFailureReason {
+  // The background fetch has not completed yet, or was successful.
+  "",
+  // The operation was aborted by the user, or abort() was called.
+  "aborted",
+  // A response had a not-ok-status.
+  "bad-status",
+  // A fetch failed for other reasons, e.g. CORS, MIX, an invalid partial response,
+  // or a general network failure for a fetch that cannot be retried.
+  "fetch-error",
+  // Storage quota was reached during the operation.
+  "quota-exceeded",
+  // The provided downloadTotal was exceeded.
+  "download-total-exceeded"
+};
+