Uses SetHeader instead of AddHeadersFromString, for code health.

So it replaced AddHeadersFromString, AddHeaderFromString
with SetHeader in ../chrome.

Bug: 862175
Change-Id: Ifec193eaf09ff75907ed4f0b0c7b29a3a724183b
Reviewed-on: https://chromium-review.googlesource.com/1154852Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Yeol Park <peary2@gmail.com>
Cr-Commit-Position: refs/heads/master@{#579721}

chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.cc

@@ -39,8 +39,8 @@ constexpr char kDeviceId[] = "device_id";
 constexpr char kDeviceType[] = "device_type";
 constexpr char kDeviceTypeArc[] = "arc_plus_plus";
 constexpr char kLoginScopedToken[] = "login_scoped_token";
-constexpr char kGetAuthCodeHeaders[] =
-    "Content-Type: application/json; charset=utf-8";
+constexpr char kGetAuthCodeKey[] = "Content-Type";
+constexpr char kGetAuthCodeValue[] = "application/json; charset=utf-8";
 constexpr char kContentTypeJSON[] = "application/json";
 
 }  // namespace
@@ -131,7 +131,7 @@ void ArcBackgroundAuthCodeFetcher::OnGetTokenSuccess(
       net::LOAD_DISABLE_CACHE | net::LOAD_BYPASS_CACHE |
       net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES;
   resource_request->method = "POST";
-  resource_request->headers.AddHeaderFromString(kGetAuthCodeHeaders);
+  resource_request->headers.SetHeader(kGetAuthCodeKey, kGetAuthCodeValue);
   simple_url_loader_ = network::SimpleURLLoader::Create(
       std::move(resource_request), traffic_annotation);
   simple_url_loader_->AttachStringForUpload(request_string, kContentTypeJSON);

chrome/browser/feedback/feedback_uploader_chrome.cc

@@ -77,8 +77,9 @@ void FeedbackUploaderChrome::AppendExtraHeadersToUploadRequest(
   if (access_token_.empty())
     return;
 
-  resource_request->headers.AddHeaderFromString(
-      base::StringPrintf("Authorization: Bearer %s", access_token_.c_str()));
+  resource_request->headers.SetHeader(
+      net::HttpRequestHeaders::kAuthorization,
+      base::StringPrintf("Bearer %s", access_token_.c_str()));
 }
 
 }  // namespace feedback

chrome/browser/profiles/profile_downloader.cc

@@ -44,7 +44,7 @@ using content::BrowserThread;
 namespace {
 
 // Template for optional authorization header when using an OAuth access token.
-constexpr char kAuthorizationHeader[] = "Authorization: Bearer %s";
+constexpr char kAuthorizationHeader[] = "Bearer %s";
 
 }  // namespace
 
@@ -235,7 +235,8 @@ void ProfileDownloader::FetchImageData() {
   resource_request->load_flags =
       net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES;
   if (!auth_token_.empty()) {
-    resource_request->headers.AddHeadersFromString(
+    resource_request->headers.SetHeader(
+        net::HttpRequestHeaders::kAuthorization,
         base::StringPrintf(kAuthorizationHeader, auth_token_.c_str()));
   }
 

chrome/browser/safe_browsing/download_protection/two_phase_uploader.cc

@@ -24,7 +24,8 @@
 namespace {
 
 // Header sent on initial request to start the two phase upload process.
-const char kStartHeader[] = "x-goog-resumable: start";
+const char kStartHeaderKey[] = "x-goog-resumable";
+const char kStartHeaderValue[] = "start";
 
 // Header returned on initial response with URL to use for the second phase.
 const char kLocationHeader[] = "Location";
@@ -154,7 +155,7 @@ void TwoPhaseUploaderImpl::UploadMetadata() {
   auto resource_request = std::make_unique<network::ResourceRequest>();
   resource_request->url = base_url_;
   resource_request->method = "POST";
-  resource_request->headers.AddHeadersFromString(kStartHeader);
+  resource_request->headers.SetHeader(kStartHeaderKey, kStartHeaderValue);
   url_loader_ = network::SimpleURLLoader::Create(std::move(resource_request),
                                                  traffic_annotation_);
   url_loader_->SetAllowHttpErrorResults(true);

chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc

@@ -201,8 +201,10 @@ void FamilyInfoFetcher::OnGetTokenSuccess(
   resource_request->url = url;
   resource_request->load_flags =
       net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES;
-  resource_request->headers.AddHeaderFromString(base::StringPrintf(
-      supervised_users::kAuthorizationHeaderFormat, access_token.c_str()));
+  resource_request->headers.SetHeader(
+      net::HttpRequestHeaders::kAuthorization,
+      base::StringPrintf(supervised_users::kAuthorizationHeaderFormat,
+                         access_token.c_str()));
   simple_url_loader_ = network::SimpleURLLoader::Create(
       std::move(resource_request), traffic_annotation);
   simple_url_loader_->SetRetryOptions(

chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc

@@ -219,8 +219,10 @@ void PermissionRequestCreatorApiary::OnGetTokenSuccess(
   resource_request->load_flags =
       net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES;
   resource_request->method = "POST";
-  resource_request->headers.AddHeaderFromString(base::StringPrintf(
-      supervised_users::kAuthorizationHeaderFormat, access_token.c_str()));
+  resource_request->headers.SetHeader(
+      net::HttpRequestHeaders::kAuthorization,
+      base::StringPrintf(supervised_users::kAuthorizationHeaderFormat,
+                         access_token.c_str()));
   (*it)->simple_url_loader = network::SimpleURLLoader::Create(
       std::move(resource_request), traffic_annotation);
   (*it)->simple_url_loader->AttachStringForUpload(body, "application/json");

chrome/browser/supervised_user/experimental/safe_search_url_reporter.cc

@@ -132,8 +132,10 @@ void SafeSearchURLReporter::OnGetTokenSuccess(
   resource_request->load_flags =
       net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES;
   resource_request->method = "POST";
-  resource_request->headers.AddHeaderFromString(base::StringPrintf(
-      supervised_users::kAuthorizationHeaderFormat, access_token.c_str()));
+  resource_request->headers.SetHeader(
+      net::HttpRequestHeaders::kAuthorization,
+      base::StringPrintf(supervised_users::kAuthorizationHeaderFormat,
+                         access_token.c_str()));
   (*it)->simple_url_loader = network::SimpleURLLoader::Create(
       std::move(resource_request), traffic_annotation);
 

chrome/browser/supervised_user/supervised_user_constants.cc

@@ -11,7 +11,7 @@ const char kAccountConsistencyMirrorRequired[] =
     "AccountConsistencyMirrorRequired";
 #endif
 const char kApprovedExtensions[] = "ApprovedExtensions";
-const char kAuthorizationHeaderFormat[] = "Authorization: Bearer %s";
+const char kAuthorizationHeaderFormat[] = "Bearer %s";
 const char kCameraMicDisabled[] = "CameraMicDisabled";
 const char kContentPackDefaultFilteringBehavior[] =
     "ContentPackDefaultFilteringBehavior";

chrome/browser/ui/desktop_ios_promotion/sms_service.cc

@@ -177,11 +177,10 @@ class RequestImpl : public SMSService::Request {
     resource_request->load_flags =
         net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES;
     resource_request->method = post_data_ ? "POST" : "GET";
-    resource_request->headers.AddHeaderFromString("Authorization: Bearer " +
-                                                  access_token);
-    resource_request->headers.AddHeaderFromString(
-        "X-Developer-Key: " +
-        GaiaUrls::GetInstance()->oauth2_chrome_client_id());
+    resource_request->headers.SetHeader(net::HttpRequestHeaders::kAuthorization,
+                                        "Bearer " + access_token);
+    resource_request->headers.SetHeader(
+        "X-Developer-Key", GaiaUrls::GetInstance()->oauth2_chrome_client_id());
     simple_url_loader_ = network::SimpleURLLoader::Create(
         std::move(resource_request), traffic_annotation);
     simple_url_loader_->SetRetryOptions(kMaxRetries,