Commit f090d8b6 authored by Dirk Pranke's avatar Dirk Pranke Committed by Commit Bot

Enable dSYMS in runtime_deps on official mac builds properly.

It turns out isolates built on Mac builds that enable_dsyms didn't
include the symbols in the .dSYM/ directories for frameworks, apps,
and plugins.

This CL fixes that.

R=bpastene@chromium.org, rsesek@chromium.org
BUG=961548

Change-Id: I60f27e7e51235cac6d4fa3c5b7c6de11c0b97819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671667Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
Reviewed-by: default avatarBen Pastene <bpastene@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671463}
parent 95750599
......@@ -351,6 +351,12 @@ template("mac_framework_bundle") {
":$_shared_library_bundle_data",
]
if (enable_dsyms) {
data = [
"$root_out_dir/$_output_name.dSYM/",
]
}
bundle_root_dir = _framework_base_dir
bundle_contents_dir = _framework_root_dir
bundle_resources_dir = "$bundle_contents_dir/Resources"
......@@ -551,6 +557,13 @@ template("mac_app_bundle") {
if (_write_pkg_info) {
deps += [ ":$_pkg_info_bundle_data" ]
}
if (enable_dsyms) {
data = [
"$root_out_dir/$_output_name.dSYM/",
]
}
product_type = _product_type
bundle_root_dir = "$root_out_dir/${_output_name}.${_output_extension}"
bundle_contents_dir = "$bundle_root_dir/Contents"
......@@ -617,6 +630,12 @@ template("mac_plugin_bundle") {
}
deps += [ ":$_loadable_module_bundle_data" ]
if (enable_dsyms) {
data = [
"$root_out_dir/$_output_name.dSYM/",
]
}
bundle_root_dir = "$root_out_dir/$_output_name.plugin"
bundle_contents_dir = "$bundle_root_dir/Contents"
bundle_executable_dir = "$bundle_contents_dir/MacOS"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment