Commit f0a67124 authored by Alan Cutter's avatar Alan Cutter Committed by Commit Bot

Disable flaky timeout OmniboxViewTest tests on TSAN and ASAN

This CL disables:
 - OmniboxViewTest.EnterToSearch
 - OmniboxViewTest.DesiredTLDWithTemporaryText
 - OmniboxViewTest.DesiredTLD
on TSAN and ASAN bots due to a high number of timeout flakes on
the trybots.

TBR=tommycli@chromium.org

Bug: 1030551
Change-Id: Ie9b0ebfacc2ea3f948e3592902f58d2a7f9f39bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965785Reviewed-by: default avatarAlan Cutter <alancutter@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724507}
parent 990f31c3
......@@ -536,7 +536,14 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, BackspaceInKeywordMode) {
UTF16ToUTF8(omnibox_view->GetText()));
}
IN_PROC_BROWSER_TEST_F(OmniboxViewTest, DesiredTLD) {
// TODO(https://crbug.com/1030551): This test flakily times out on ASAN and
// TSAN.
#if defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER)
#define MAYBE_DesiredTLD DISABLED_DesiredTLD
#else
#define MAYBE_DesiredTLD DesiredTLD
#endif
IN_PROC_BROWSER_TEST_F(OmniboxViewTest, MAYBE_DesiredTLD) {
OmniboxView* omnibox_view = NULL;
ASSERT_NO_FATAL_FAILURE(GetOmniboxView(&omnibox_view));
OmniboxPopupModel* popup_model = omnibox_view->model()->popup_model();
......@@ -556,7 +563,14 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, DesiredTLD) {
NavigateExpectUrl(GURL("http://www.bar.com/"), ui::EF_CONTROL_DOWN));
}
IN_PROC_BROWSER_TEST_F(OmniboxViewTest, DesiredTLDWithTemporaryText) {
// TODO(https://crbug.com/1030551): This test flakily times out on ASAN and
// TSAN.
#if defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER)
#define MAYBE_DesiredTLDWithTemporaryText DISABLED_DesiredTLDWithTemporaryText
#else
#define MAYBE_DesiredTLDWithTemporaryText DesiredTLDWithTemporaryText
#endif
IN_PROC_BROWSER_TEST_F(OmniboxViewTest, MAYBE_DesiredTLDWithTemporaryText) {
OmniboxView* omnibox_view = NULL;
ASSERT_NO_FATAL_FAILURE(GetOmniboxView(&omnibox_view));
OmniboxPopupModel* popup_model = omnibox_view->model()->popup_model();
......@@ -639,7 +653,14 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, AltEnter) {
ASSERT_NO_FATAL_FAILURE(WaitForTabOpenOrClose(tab_count + 1));
}
IN_PROC_BROWSER_TEST_F(OmniboxViewTest, EnterToSearch) {
// TODO(https://crbug.com/1030551): This test flakily times out on ASAN and
// TSAN.
#if defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER)
#define MAYBE_EnterToSearch DISABLED_EnterToSearch
#else
#define MAYBE_EnterToSearch EnterToSearch
#endif
IN_PROC_BROWSER_TEST_F(OmniboxViewTest, MAYBE_EnterToSearch) {
OmniboxView* omnibox_view = NULL;
ASSERT_NO_FATAL_FAILURE(GetOmniboxView(&omnibox_view));
OmniboxPopupModel* popup_model = omnibox_view->model()->popup_model();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment