[LayoutNG] Remove has_orthogonal_flow_roots_ flag.

There should be no behaviour change.

Change-Id: I972509c2ce8e28dcd6542b0b9531d1c0a961dd1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244971
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795164}

third_party/blink/renderer/core/layout/ng/inline/ng_line_box_fragment_builder.cc

@@ -31,7 +31,6 @@ void NGLineBoxFragmentBuilder::Reset() {
 
   break_appeal_ = kBreakAppealPerfect;
   has_floating_descendants_for_paint_ = false;
-  has_orthogonal_flow_roots_ = false;
   has_descendant_that_depends_on_percentage_block_size_ = false;
   has_block_fragmentation_ = false;
 }

third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.cc

@@ -89,13 +89,6 @@ void NGContainerFragmentBuilder::PropagateChildData(
     }
   }
 
-  // For the |has_orthogonal_flow_roots_| flag, we don't care about the type of
-  // child (OOF-positioned, etc), it is for *any* descendant.
-  if (child.HasOrthogonalFlowRoots() ||
-      !IsParallelWritingMode(child.Style().GetWritingMode(),
-                             Style().GetWritingMode()))
-    has_orthogonal_flow_roots_ = true;
-
   // We only need to report if inflow or floating elements depend on the
   // percentage resolution block-size. OOF-positioned children resolve their
   // percentages against the "final" size of their parent.

third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.h

@@ -258,7 +258,6 @@ class CORE_EXPORT NGContainerFragmentBuilder : public NGFragmentBuilder {
   bool is_legacy_layout_root_ = false;
 
   bool has_floating_descendants_for_paint_ = false;
-  bool has_orthogonal_flow_roots_ = false;
   bool has_descendant_that_depends_on_percentage_block_size_ = false;
   bool has_block_fragmentation_ = false;
   bool is_fragmentation_context_root_ = false;

third_party/blink/renderer/core/layout/ng/ng_physical_box_fragment.cc

@@ -547,7 +547,6 @@ void NGPhysicalBoxFragment::CheckSameForSimplifiedLayout(
   DCHECK_EQ(is_hidden_for_paint_, other.is_hidden_for_paint_);
 
   // |has_floating_descendants_for_paint_| can change during simplified layout.
-  DCHECK_EQ(has_orthogonal_flow_roots_, other.has_orthogonal_flow_roots_);
   DCHECK_EQ(may_have_descendant_above_block_start_,
             other.may_have_descendant_above_block_start_);
   DCHECK_EQ(depends_on_percentage_block_size_,

third_party/blink/renderer/core/layout/ng/ng_physical_container_fragment.cc

@@ -51,7 +51,6 @@ NGPhysicalContainerFragment::NGPhysicalContainerFragment(
       builder->has_floating_descendants_for_paint_;
   has_adjoining_object_descendants_ =
       builder->has_adjoining_object_descendants_;
-  has_orthogonal_flow_roots_ = builder->has_orthogonal_flow_roots_;
   depends_on_percentage_block_size_ = DependsOnPercentageBlockSize(*builder);
 
   PhysicalSize size = Size();

third_party/blink/renderer/core/layout/ng/ng_physical_container_fragment.h

@@ -135,9 +135,6 @@ class CORE_EXPORT NGPhysicalContainerFragment : public NGPhysicalFragment {
     return has_adjoining_object_descendants_;
   }
 
-  // TODO(ikilpatrick): Remove this flag as its not used anymore.
-  bool HasOrthogonalFlowRoots() const { return has_orthogonal_flow_roots_; }
-
   // Returns true if we aren't able to re-use this fragment if the
   // |NGConstraintSpace::PercentageResolutionBlockSize| changes.
   bool DependsOnPercentageBlockSize() const {

third_party/blink/renderer/core/layout/ng/ng_physical_fragment.h

@@ -430,7 +430,6 @@ class CORE_EXPORT NGPhysicalFragment
   // (it's defined here to save memory, since that class has no bitfields).
   unsigned has_floating_descendants_for_paint_ : 1;
   unsigned has_adjoining_object_descendants_ : 1;
-  unsigned has_orthogonal_flow_roots_ : 1;
   unsigned depends_on_percentage_block_size_ : 1;
 
   // The following bitfields are only to be used by NGPhysicalLineBoxFragment