RC: Remove a static initializer.

See https://chromium-review.googlesource.com/c/chromium/src/+/1231633 for more details about this issue.

Bug: 844426
Change-Id: Icad060f8105602a2e0805e55f6ffd8b11ce5effa
Reviewed-on: https://chromium-review.googlesource.com/1231815Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592159}

chrome/browser/about_flags.cc

@@ -1218,13 +1218,13 @@ const FeatureEntry::FeatureVariation
 
 #if !defined(OS_ANDROID)
 const FeatureEntry::FeatureParam kProactiveTabFreezeAndDiscard_FreezeOnly[] = {
-    {resource_coordinator::ProactiveTabFreezeAndDiscardParams::
-         kShouldProactivelyDiscard.name,
+    {resource_coordinator::
+         kProactiveTabFreezeAndDiscard_ShouldProactivelyDiscardParam,
      "false"}};
 const FeatureEntry::FeatureParam
     kProactiveTabFreezeAndDiscard_FreezeAndDiscard[] = {
-        {resource_coordinator::ProactiveTabFreezeAndDiscardParams::
-             kShouldProactivelyDiscard.name,
+        {resource_coordinator::
+             kProactiveTabFreezeAndDiscard_ShouldProactivelyDiscardParam,
          "true"}};
 const FeatureEntry::FeatureVariation kProactiveTabFreezeAndDiscardVariations[] =
     {{"Freeze only", kProactiveTabFreezeAndDiscard_FreezeOnly,
@@ -4235,7 +4235,7 @@ const FeatureEntry kFeatureEntries[] = {
      FEATURE_WITH_PARAMS_VALUE_TYPE(
          features::kProactiveTabFreezeAndDiscard,
          kProactiveTabFreezeAndDiscardVariations,
-         features::kProactiveTabFreezeAndDiscard.name)},
+         resource_coordinator::kProactiveTabFreezeAndDiscardFeatureName)},
     {"site-characteristics-database",
      flag_descriptions::kSiteCharacteristicsDatabaseName,
      flag_descriptions::kSiteCharacteristicsDatabaseDescription, kOsDesktop,

chrome/browser/resource_coordinator/tab_manager_features.cc

@@ -30,7 +30,8 @@ const base::Feature kInfiniteSessionRestore{"InfiniteSessionRestore",
 
 // Enables proactive tab freezing and discarding.
 const base::Feature kProactiveTabFreezeAndDiscard{
-    "ProactiveTabFreezeAndDiscard", base::FEATURE_DISABLED_BY_DEFAULT};
+    resource_coordinator::kProactiveTabFreezeAndDiscardFeatureName,
+    base::FEATURE_DISABLED_BY_DEFAULT};
 
 // Enables the site characteristics database.
 const base::Feature kSiteCharacteristicsDatabase{
@@ -78,6 +79,11 @@ int GetModerateThresholdTabCountBasedOnSystemMemory(
 
 }  // namespace
 
+const char kProactiveTabFreezeAndDiscardFeatureName[] =
+    "ProactiveTabFreezeAndDiscard";
+const char kProactiveTabFreezeAndDiscard_ShouldProactivelyDiscardParam[] =
+    "ShouldProactivelyDiscard";
+
 // Instantiate the feature parameters for proactive tab discarding.
 constexpr base::FeatureParam<bool>
     ProactiveTabFreezeAndDiscardParams::kShouldProactivelyDiscard;

chrome/browser/resource_coordinator/tab_manager_features.h

@@ -25,6 +25,13 @@ extern const base::Feature kTabRanker;
 
 namespace resource_coordinator {
 
+// The name of the ProactiveTabFreezeAndDiscard feature.
+extern const char kProactiveTabFreezeAndDiscardFeatureName[];
+
+// The name of the |ShouldProactivelyDiscard| parameter of the
+// ProactiveTabFreezeAndDiscard feature.
+extern const char kProactiveTabFreezeAndDiscard_ShouldProactivelyDiscardParam[];
+
 // Parameters used by the proactive tab discarding feature.
 //
 // Proactive discarding has 5 key parameters:
@@ -69,8 +76,8 @@ struct ProactiveTabFreezeAndDiscardParams {
   // feature.
 
   static constexpr base::FeatureParam<bool> kShouldProactivelyDiscard{
-      &features::kProactiveTabFreezeAndDiscard, "ShouldProactivelyDiscard",
-      false};
+      &features::kProactiveTabFreezeAndDiscard,
+      kProactiveTabFreezeAndDiscard_ShouldProactivelyDiscardParam, false};
   static constexpr base::FeatureParam<bool> kShouldPeriodicallyUnfreeze{
       &features::kProactiveTabFreezeAndDiscard, "ShouldPeriodicallyUnfreeze",
       false};