Commit f1292212 authored by Nico Weber's avatar Nico Weber

Remove PlatformAppBrowserTest.PrintPreviewShouldNotBeTooSmall.

When the test was added in https://codereview.chromium.org/26678004/
it only passed on macOS. Since macviews it no longer passes anywhere,
so just delete it.

Bug: 832676
Change-Id: Ie5b3f476f96d7f750612f58ac0c4f9016166ab11
Reviewed-on: https://chromium-review.googlesource.com/1255205Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595508}
parent 1c7caf2f
......@@ -32,7 +32,6 @@
#include "chrome/browser/ui/extensions/app_launch_params.h"
#include "chrome/browser/ui/extensions/application_launch.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/views_mode_controller.h"
#include "chrome/browser/ui/webui/print_preview/print_preview_ui.h"
#include "chrome/browser/ui/zoom/chrome_zoom_level_prefs.h"
#include "chrome/common/chrome_switches.h"
......@@ -1158,35 +1157,6 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
GetFirstAppWindow()->GetBaseWindow()->Close();
}
// This test currently only passes on OS X (on other platforms the print preview
// dialog's size is limited by the size of the window being printed). It also
// doesn't pass in Views mode on OS X.
#if !defined(OS_MACOSX)
#define MAYBE_PrintPreviewShouldNotBeTooSmall \
DISABLED_PrintPreviewShouldNotBeTooSmall
#else
#define MAYBE_PrintPreviewShouldNotBeTooSmall PrintPreviewShouldNotBeTooSmall
#endif
IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
MAYBE_PrintPreviewShouldNotBeTooSmall) {
#if defined(OS_MACOSX)
if (!views_mode_controller::IsViewsBrowserCocoa())
return;
#endif
// Print preview dialogs with widths less than 410 pixels will have preview
// areas that are too small, and ones with heights less than 191 pixels will
// have vertical scrollers for their controls that are too small.
gfx::Size minimum_dialog_size(410, 191);
ScopedPreviewTestingDelegate preview_delegate;
ASSERT_TRUE(RunPlatformAppTest("platform_apps/print_api")) << message_;
preview_delegate.WaitUntilPreviewIsReady();
EXPECT_GE(preview_delegate.dialog_size().width(),
minimum_dialog_size.width());
EXPECT_GE(preview_delegate.dialog_size().height(),
minimum_dialog_size.height());
GetFirstAppWindow()->GetBaseWindow()->Close();
}
#endif // ENABLE_PRINT_PREVIEW
#if defined(OS_CHROMEOS)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment