Commit f139fb84 authored by tzik's avatar tzik Committed by Commit bot

Inline StringCallback::scheduleCallback to the caller

Review-Url: https://codereview.chromium.org/2586173003
Cr-Commit-Position: refs/heads/master@{#439457}
parent 87681be8
......@@ -33,9 +33,13 @@
#include "bindings/core/v8/V8Binding.h"
#include "core/clipboard/DataObjectItem.h"
#include "core/clipboard/DataTransfer.h"
#include "core/dom/ExecutionContext.h"
#include "core/dom/ExecutionContextTask.h"
#include "core/dom/StringCallback.h"
#include "core/dom/TaskRunnerHelper.h"
#include "public/platform/WebTraceLocation.h"
#include "wtf/StdLibExtras.h"
#include "wtf/text/WTFString.h"
namespace blink {
......@@ -72,9 +76,11 @@ void DataTransferItem::getAsString(ExecutionContext* context,
if (!callback || m_item->kind() != DataObjectItem::StringKind)
return;
StringCallback::scheduleCallback(TaskType::UserInteraction, callback, context,
m_item->getAsString(),
"DataTransferItem.getAsString");
context->postTask(
TaskType::UserInteraction, BLINK_FROM_HERE,
createSameThreadTask(&StringCallback::handleEvent,
wrapPersistent(callback), m_item->getAsString()),
"DataTransferItem.getAsString");
}
Blob* DataTransferItem::getAsFile() const {
......
......@@ -249,7 +249,6 @@ blink_core_sources("dom") {
"StaticNodeList.h",
"StaticRange.cpp",
"StaticRange.h",
"StringCallback.cpp",
"StringCallback.h",
"StyleChangeReason.cpp",
"StyleChangeReason.h",
......
/*
* Copyright (C) 2010 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
* met:
*
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the following disclaimer
* in the documentation and/or other materials provided with the
* distribution.
* * Neither the name of Google Inc. nor the names of its
* contributors may be used to endorse or promote products derived from
* this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "core/dom/StringCallback.h"
#include "core/dom/ExecutionContext.h"
#include "core/dom/ExecutionContextTask.h"
#include "core/dom/TaskRunnerHelper.h"
#include "public/platform/WebTraceLocation.h"
#include "wtf/text/WTFString.h"
namespace blink {
void StringCallback::scheduleCallback(TaskType taskType,
StringCallback* callback,
ExecutionContext* context,
const String& data,
const String& instrumentationName) {
context->postTask(taskType, BLINK_FROM_HERE,
createSameThreadTask(&StringCallback::handleEvent,
wrapPersistent(callback), data),
instrumentationName);
}
} // namespace blink
......@@ -36,21 +36,11 @@
namespace blink {
class ExecutionContext;
enum class TaskType : unsigned;
class StringCallback : public GarbageCollectedFinalized<StringCallback> {
public:
virtual ~StringCallback() {}
DEFINE_INLINE_VIRTUAL_TRACE() {}
virtual void handleEvent(const String& data) = 0;
// Helper to post callback task.
static void scheduleCallback(TaskType,
StringCallback*,
ExecutionContext*,
const String& data,
const String& instrumentationName);
};
} // namespace blink
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment