Commit f179f6cf authored by Zhenyao Mo's avatar Zhenyao Mo Committed by Commit Bot

Remove histogram GPU.Error_TexImage{2|3}D

BUG=1037113
TEST=bots
R=magchen@chromium.org

Change-Id: I17a8850477bf43010ad7c6febb059d6b4a34071e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981189Reviewed-by: default avatarMaggie Chen <magchen@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727319}
parent 88b37058
...@@ -7,7 +7,6 @@ ...@@ -7,7 +7,6 @@
#include <algorithm> #include <algorithm>
#include <unordered_set> #include <unordered_set>
#include "base/metrics/histogram.h"
#include "gpu/command_buffer/common/capabilities.h" #include "gpu/command_buffer/common/capabilities.h"
#include "gpu/command_buffer/service/error_state.h" #include "gpu/command_buffer/service/error_state.h"
#include "gpu/command_buffer/service/feature_info.h" #include "gpu/command_buffer/service/feature_info.h"
...@@ -107,18 +106,6 @@ const char* GetDebugSeverityString(GLenum severity) { ...@@ -107,18 +106,6 @@ const char* GetDebugSeverityString(GLenum severity) {
} }
} // namespace } // namespace
std::vector<int> GetAllGLErrors() {
int gl_errors[] = {
GL_NO_ERROR,
GL_INVALID_ENUM,
GL_INVALID_VALUE,
GL_INVALID_OPERATION,
GL_INVALID_FRAMEBUFFER_OPERATION,
GL_OUT_OF_MEMORY,
};
return base::CustomHistogram::ArrayToCustomEnumRanges(gl_errors);
}
bool PrecisionMeetsSpecForHighpFloat(GLint rangeMin, bool PrecisionMeetsSpecForHighpFloat(GLint rangeMin,
GLint rangeMax, GLint rangeMax,
GLint precision) { GLint precision) {
......
...@@ -9,7 +9,6 @@ ...@@ -9,7 +9,6 @@
#define GPU_COMMAND_BUFFER_SERVICE_GL_UTILS_H_ #define GPU_COMMAND_BUFFER_SERVICE_GL_UTILS_H_
#include <string> #include <string>
#include <vector>
#include "build/build_config.h" #include "build/build_config.h"
#include "gpu/command_buffer/common/constants.h" #include "gpu/command_buffer/common/constants.h"
...@@ -64,8 +63,6 @@ struct CALayerSharedState { ...@@ -64,8 +63,6 @@ struct CALayerSharedState {
gfx::Transform transform; gfx::Transform transform;
}; };
std::vector<int> GetAllGLErrors();
bool PrecisionMeetsSpecForHighpFloat(GLint rangeMin, bool PrecisionMeetsSpecForHighpFloat(GLint rangeMin,
GLint rangeMax, GLint rangeMax,
GLint precision); GLint precision);
......
...@@ -15,7 +15,6 @@ ...@@ -15,7 +15,6 @@
#include "base/bits.h" #include "base/bits.h"
#include "base/format_macros.h" #include "base/format_macros.h"
#include "base/lazy_instance.h" #include "base/lazy_instance.h"
#include "base/metrics/histogram_macros.h"
#include "base/stl_util.h" #include "base/stl_util.h"
#include "base/strings/stringprintf.h" #include "base/strings/stringprintf.h"
#include "base/threading/thread_task_runner_handle.h" #include "base/threading/thread_task_runner_handle.h"
...@@ -3696,13 +3695,6 @@ void TextureManager::DoTexImage(DecoderTextureState* texture_state, ...@@ -3696,13 +3695,6 @@ void TextureManager::DoTexImage(DecoderTextureState* texture_state,
} }
} }
GLenum error = ERRORSTATE_PEEK_GL_ERROR(error_state, function_name); GLenum error = ERRORSTATE_PEEK_GL_ERROR(error_state, function_name);
if (args.command_type == DoTexImageArguments::CommandType::kTexImage3D) {
UMA_HISTOGRAM_CUSTOM_ENUMERATION("GPU.Error_TexImage3D", error,
GetAllGLErrors());
} else {
UMA_HISTOGRAM_CUSTOM_ENUMERATION("GPU.Error_TexImage2D", error,
GetAllGLErrors());
}
if (error == GL_NO_ERROR) { if (error == GL_NO_ERROR) {
bool set_as_cleared = (args.pixels != nullptr || unpack_buffer_bound); bool set_as_cleared = (args.pixels != nullptr || unpack_buffer_bound);
SetLevelInfo( SetLevelInfo(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment