Commit f17f0d66 authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

SELECT popup: Don't move a popup while it is shown on Windows.

Windows Aura(?) has a bug on moving a popup window.  See crbug.com/863770.
This CL reverts a part of crrev.com/370091, and SELECT popups won't be
moved to work around the issue.

Bug: 137495, 863770
Change-Id: I1d50aa6eb47204b8fe6ea83fddba6966861dff76
Reviewed-on: https://chromium-review.googlesource.com/1143062Reviewed-by: default avatarKeishi Hattori <keishi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576416}
parent 68fb37b7
PASS popupWindow.innerWidth is 100
PASS popupWindow.innerWidth is 150
FAIL Popup wasn't resized.
PASS successfullyParsed is true
TEST COMPLETE
......
......@@ -24,6 +24,10 @@ var menu = document.getElementById('menu');
openPicker(menu, function() {
shouldBe('popupWindow.innerWidth', '100');
popupWindow.addEventListener("resize", checkPopupWidth, false);
setTimeout(function() {
testFailed('Popup wasn\'t resized.');
finishJSTest();
}, 3000);
menu.style.width = "150px";
menu.offsetTop;
}, openPickerErrorCallback);
......
PASS popupWindow.innerWidth is 100
PASS popupWindow.innerWidth is 150
PASS successfullyParsed is true
TEST COMPLETE
......@@ -83,8 +83,12 @@ ListPicker.prototype._handleWindowMessage = function(event) {
this._config.anchorRectInScreen.y !== window.updateData.anchorRectInScreen.y ||
this._config.anchorRectInScreen.width !== window.updateData.anchorRectInScreen.width ||
this._config.anchorRectInScreen.height !== window.updateData.anchorRectInScreen.height) {
this._config.anchorRectInScreen = window.updateData.anchorRectInScreen;
this._fixWindowSize();
// TODO(tkent): Don't fix window size here due to a bug of Aura or
// compositor. crbug.com/863770
if (!navigator.platform.startsWith('Win')) {
this._config.anchorRectInScreen = window.updateData.anchorRectInScreen;
this._fixWindowSize();
}
}
}
delete window.updateData;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment