Fix two crashes from the incognito notification.

1.) The repost form warning should use dismissAllowingStateLoss
    for the tab destroy call as it can happen in the background.
    For this dialog in particular, we do not want to restore
    it in the event of a restart, so loss of UI state is not
    only acceptable, but likely what we want always.

2.) Handle the case of tabbed activities in the process of startup
    when clicking the incognito notification.  This just kills
    any tabbed activities that aren't fully running because it
    has sync issues with incognito tabs that might have been read
    already.

BUG=856320

Change-Id: Ic3506d20d42cb915328394f18dcad5574d8dca7e
Reviewed-on: https://chromium-review.googlesource.com/1114279Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570257}

chrome/android/java/src/org/chromium/chrome/browser/RepostFormWarningDialog.java

@@ -46,7 +46,7 @@ public class RepostFormWarningDialog extends DialogFragment {
         mTabObserver = new EmptyTabObserver() {
             @Override
             public void onDestroyed(Tab tab) {
-                dismiss();
+                dismissAllowingStateLoss();
             }
         };
         mTab.addObserver(mTabObserver);
@@ -113,6 +113,12 @@ public class RepostFormWarningDialog extends DialogFragment {
         super.dismiss();
     }
 
+    @Override
+    public void dismissAllowingStateLoss() {
+        if (getFragmentManager() == null) return;
+        super.dismissAllowingStateLoss();
+    }
+
     @Override
     public void onDismiss(DialogInterface dialog) {
         super.onDismiss(dialog);

chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java

@@ -71,35 +71,28 @@ public class IncognitoNotificationService extends IntentService {
         // If we failed clearing all of the incognito tabs, then do not dismiss the notification.
         if (!clearedIncognito) return;
 
-        ThreadUtils.runOnUiThreadBlocking(new Runnable() {
-            @Override
-            public void run() {
-                if (!TabWindowManager.getInstance().canDestroyIncognitoProfile()) {
-                    assert false : "Not all incognito tabs closed as expected";
-                    return;
-                }
-                IncognitoNotificationManager.dismissIncognitoNotification();
-
-                if (BrowserStartupController.get(LibraryProcessType.PROCESS_BROWSER)
-                        .isStartupSuccessfullyCompleted()) {
-                    if (Profile.getLastUsedProfile().hasOffTheRecordProfile()) {
-                        Profile.getLastUsedProfile().getOffTheRecordProfile()
-                                .destroyWhenAppropriate();
-                    }
+        ThreadUtils.runOnUiThreadBlocking(() -> {
+            if (!TabWindowManager.getInstance().canDestroyIncognitoProfile()) {
+                assert false : "Not all incognito tabs closed as expected";
+                return;
+            }
+            IncognitoNotificationManager.dismissIncognitoNotification();
+
+            if (BrowserStartupController.get(LibraryProcessType.PROCESS_BROWSER)
+                            .isStartupSuccessfullyCompleted()) {
+                if (Profile.getLastUsedProfile().hasOffTheRecordProfile()) {
+                    Profile.getLastUsedProfile().getOffTheRecordProfile().destroyWhenAppropriate();
                 }
             }
         });
 
-        ThreadUtils.runOnUiThreadBlocking(new Runnable() {
-            @Override
-            public void run() {
-                // Now ensure that the snapshots in recents are all cleared for Tabbed activities
-                // to remove any trace of incognito mode.
-                if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) {
-                    focusChromeIfNecessary();
-                } else {
-                    removeNonVisibleChromeTabbedRecentEntries();
-                }
+        ThreadUtils.runOnUiThreadBlocking(() -> {
+            // Now ensure that the snapshots in recents are all cleared for Tabbed activities
+            // to remove any trace of incognito mode.
+            if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) {
+                focusChromeIfNecessary();
+            } else {
+                removeNonVisibleChromeTabbedRecentEntries();
             }
         });
     }
@@ -180,22 +173,26 @@ public class IncognitoNotificationService extends IntentService {
      * @see TabWindowManager#getIndexForWindow(Activity)
      */
     private void closeIncognitoTabsInRunningTabbedActivities() {
-        ThreadUtils.runOnUiThreadBlocking(new Runnable() {
-            @Override
-            public void run() {
-                List<WeakReference<Activity>> runningActivities =
-                        ApplicationStatus.getRunningActivities();
-                for (int i = 0; i < runningActivities.size(); i++) {
-                    Activity activity = runningActivities.get(i).get();
-                    if (activity == null) continue;
-                    if (!(activity instanceof ChromeTabbedActivity)) continue;
-
-                    ChromeTabbedActivity tabbedActivity = (ChromeTabbedActivity) activity;
-                    if (tabbedActivity.isActivityDestroyed()) continue;
-
-                    tabbedActivity.getTabModelSelector().getModel(true).closeAllTabs(
-                            false, false);
+        ThreadUtils.runOnUiThreadBlocking(() -> {
+            List<WeakReference<Activity>> runningActivities =
+                    ApplicationStatus.getRunningActivities();
+            for (int i = 0; i < runningActivities.size(); i++) {
+                Activity activity = runningActivities.get(i).get();
+                if (activity == null) continue;
+                if (!(activity instanceof ChromeTabbedActivity)) continue;
+
+                ChromeTabbedActivity tabbedActivity = (ChromeTabbedActivity) activity;
+                if (tabbedActivity.isActivityDestroyed()) continue;
+
+                // If the tabbed activity has not yet initialized, then finish the activity to avoid
+                // timing issues with clearing the incognito tab state in the background.
+                if (!tabbedActivity.areTabModelsInitialized()
+                        || !tabbedActivity.didFinishNativeInitialization()) {
+                    tabbedActivity.finish();
+                    continue;
                 }
+
+                tabbedActivity.getTabModelSelector().getModel(true).closeAllTabs(false, false);
             }
         });
     }