Don't insert tab characters into <input type=color> on mac
This is the same issue/fix as crrev.com/703403 but for mac. On mac WebPagePopupImpl::HandleKeyEvent is called instead of WebPagePopupImpl::HandleCharEvent, but I'm not sure why. fast/forms/color/color-picker-no-tab-character.html should have already been testing this, but when the test is run on mac it doesn't actually insert tab characters into the input elements, which does happen when testing it manually. After doing much debugging, I wasn't able to figure out why, but I did find that keypress events are another observable side effect which happens in parallel with inserting tab characters, so I added a check for it to color-picker-no-tab-character.html as a test for this change. Fixes: 1146693 Bug: 1011168 Change-Id: Ib395fdad80d92452158c867bafb867e8db08e597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524290Reviewed-by:Mason Freed <masonfreed@chromium.org> Reviewed-by:
Sanket Joshi <sajos@microsoft.com> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#825408}
Showing
Please register or sign in to comment