[ios] Fixes testRecentTabSigninPromoReloadedWhileHidden.

Recent Tabs tableview cells are no longer marked with the Button a11y trait, so
the matcher for the "Other Devices" button needed to be updated accordingly.

BUG=825431
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2daa26fb0b2aa2fa45d4df0b62361f512fcb243e
Reviewed-on: https://chromium-review.googlesource.com/1008046Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549961}

ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_egtest.mm

@@ -185,10 +185,13 @@ id<GREYMatcher> TitleOfTestPage() {
                           closeButton:NO];
 
   // Tap on "Other Devices", to hide the sign-in promo.
-  [[EarlGrey
-      selectElementWithMatcher:chrome_test_util::ButtonWithAccessibilityLabel(
-                                   l10n_util::GetNSString(
-                                       IDS_IOS_RECENT_TABS_OTHER_DEVICES))]
+  NSString* otherDevicesLabel =
+      l10n_util::GetNSString(IDS_IOS_RECENT_TABS_OTHER_DEVICES);
+  id<GREYMatcher> otherDevicesMatcher =
+      IsUIRefreshPhase1Enabled()
+          ? grey_accessibilityLabel(otherDevicesLabel)
+          : chrome_test_util::ButtonWithAccessibilityLabel(otherDevicesLabel);
+  [[EarlGrey selectElementWithMatcher:otherDevicesMatcher]
       performAction:grey_tap()];
   [SigninEarlGreyUtils checkSigninPromoNotVisible];
 
@@ -197,11 +200,8 @@ id<GREYMatcher> TitleOfTestPage() {
   ios::FakeChromeIdentityService::GetInstanceFromChromeProvider()->AddIdentity(
       identity);
 
-  // Tap on "Other Devcies", to show the sign-in promo.
-  [[EarlGrey
-      selectElementWithMatcher:chrome_test_util::ButtonWithAccessibilityLabel(
-                                   l10n_util::GetNSString(
-                                       IDS_IOS_RECENT_TABS_OTHER_DEVICES))]
+  // Tap on "Other Devices", to show the sign-in promo.
+  [[EarlGrey selectElementWithMatcher:otherDevicesMatcher]
       performAction:grey_tap()];
   [SigninEarlGreyUtils
       checkSigninPromoVisibleWithMode:SigninPromoViewModeWarmState