Commit f252b9a0 authored by csilv@chromium.org's avatar csilv@chromium.org

[ntp4] Set login_status_url dynamically to prevent a javascript console warning.

BUG=105997
TEST=Open NTP, verify that no warnings appear in console.
Review URL: http://codereview.chromium.org/8776054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112810 0039d316-1c4b-4281-b951-d872f2087c98
parent d6ca409b
...@@ -123,7 +123,7 @@ ...@@ -123,7 +123,7 @@
<div id="login-status-message-container"> <div id="login-status-message-container">
<span i18n-content="login_status_message"></span> <span i18n-content="login_status_message"></span>
<a id="login-status-learn-more" i18n-content="login_status_learn_more" <a id="login-status-learn-more" i18n-content="login_status_learn_more"
i18n-values="href:login_status_url" target="_blank"></a> target="_blank"></a>
</div> </div>
<div id="login-status-action-area"> <div id="login-status-action-area">
<div id="login-status-advanced-container"> <div id="login-status-advanced-container">
......
...@@ -120,17 +120,16 @@ cr.define('ntp4', function() { ...@@ -120,17 +120,16 @@ cr.define('ntp4', function() {
loginBubble.deactivateToDismissDelay = 2000; loginBubble.deactivateToDismissDelay = 2000;
loginBubble.setCloseButtonVisible(false); loginBubble.setCloseButtonVisible(false);
var bubbleContent = $('login-status-bubble-contents'); $('login-status-learn-more').href =
loginBubble.content = bubbleContent; localStrings.getString('login_status_url');
bubbleContent.hidden = false; $('login-status-advanced').onclick = function() {
var advancedButton = loginBubble.querySelector('#login-status-advanced');
advancedButton.onclick = function() {
chrome.send('showAdvancedLoginUI'); chrome.send('showAdvancedLoginUI');
} }
$('login-status-dismiss').onclick = loginBubble.hide.bind(loginBubble);
var dismissButton = loginBubble.querySelector('#login-status-dismiss'); var bubbleContent = $('login-status-bubble-contents');
dismissButton.onclick = loginBubble.hide.bind(loginBubble); loginBubble.content = bubbleContent;
bubbleContent.hidden = false;
// The anchor node won't be updated until updateLogin is called so don't // The anchor node won't be updated until updateLogin is called so don't
// show the bubble yet. // show the bubble yet.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment