Commit f2808ea1 authored by kouhei's avatar kouhei Committed by Commit bot

Run GC after each memory test page

Before this CL, no GC was run in between test, so setting --pageset-repeat > 1
lead to increased memory usage per test run, reporting inaccurate results.
This CL forces V8 GC (and attached Oilpan GC) after each test run for stable result.

More background:
Blink used to trigger V8 major GC after page unload, but this was changed to
less aggressive GC since r181187, suspected as source of this "leak".

BUG=465997

Review URL: https://codereview.chromium.org/1027133002

Cr-Commit-Position: refs/heads/master@{#322318}
parent f0aa3f70
...@@ -24,6 +24,9 @@ class Memory(page_test.PageTest): ...@@ -24,6 +24,9 @@ class Memory(page_test.PageTest):
self._memory_metric.Start(page, tab) self._memory_metric.Start(page, tab)
self._power_metric.Start(page, tab) self._power_metric.Start(page, tab)
def CleanUpAfterPage(self, page, tab):
tab.CollectGarbage()
def CustomizeBrowserOptions(self, options): def CustomizeBrowserOptions(self, options):
memory.MemoryMetric.CustomizeBrowserOptions(options) memory.MemoryMetric.CustomizeBrowserOptions(options)
# Since this is a memory benchmark, we want to sample memory histograms at # Since this is a memory benchmark, we want to sample memory histograms at
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment