Commit f28ad352 authored by Koji Ishii's avatar Koji Ishii Committed by Commit Bot

[LayoutNG] flag-specific rebaselines after list marker change

This patch rebaselines image and/or text failures after the
list marker change in CL:994915.

The CL prevents list markers overlapping with previous content
by including the list marker height into the list item. While
it is slightly differnet from what Blink does, I think this is
reasonably close to rebaseline, given the behavior is not well-
defined and Gecko behaves differently.

We may revisit this if this difference turned out to be more
significant than I think.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 725277
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I773bc19ca2d27c96266d15d75b8f20de12952b30
Reviewed-on: https://chromium-review.googlesource.com/1013674
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550925}
parent 73552e8d
...@@ -1088,7 +1088,6 @@ crbug.com/591099 fast/css/case-transform.html [ Failure ] ...@@ -1088,7 +1088,6 @@ crbug.com/591099 fast/css/case-transform.html [ Failure ]
crbug.com/591099 fast/css/containment/size-and-layout-containment.html [ Failure ] crbug.com/591099 fast/css/containment/size-and-layout-containment.html [ Failure ]
crbug.com/591099 fast/css/content-counter-010.htm [ Failure ] crbug.com/591099 fast/css/content-counter-010.htm [ Failure ]
crbug.com/591099 fast/css/css-properties-position-relative-as-parent-fixed.html [ Failure ] crbug.com/591099 fast/css/css-properties-position-relative-as-parent-fixed.html [ Failure ]
crbug.com/591099 fast/css/first-child-pseudo-class.html [ Failure ]
crbug.com/714962 fast/css/first-letter-before-hit-test.html [ Failure ] crbug.com/714962 fast/css/first-letter-before-hit-test.html [ Failure ]
crbug.com/714962 fast/css/first-letter-hit-test.html [ Failure ] crbug.com/714962 fast/css/first-letter-hit-test.html [ Failure ]
crbug.com/714962 fast/css/first-letter-hover-hit-test.html [ Failure ] crbug.com/714962 fast/css/first-letter-hover-hit-test.html [ Failure ]
...@@ -1097,7 +1096,6 @@ crbug.com/714962 fast/css/first-line-change-color.html [ Failure ] ...@@ -1097,7 +1096,6 @@ crbug.com/714962 fast/css/first-line-change-color.html [ Failure ]
crbug.com/714962 fast/css/first-line-hover-001.html [ Failure ] crbug.com/714962 fast/css/first-line-hover-001.html [ Failure ]
crbug.com/591099 fast/css/first-line-text-decoration-inherited-from-parent.html [ Failure ] crbug.com/591099 fast/css/first-line-text-decoration-inherited-from-parent.html [ Failure ]
crbug.com/591099 fast/css/first-line-text-decoration.html [ Failure ] crbug.com/591099 fast/css/first-line-text-decoration.html [ Failure ]
crbug.com/591099 fast/css/first-of-type-pseudo-class.html [ Failure ]
crbug.com/591099 fast/css/focus-ring-continuations.html [ Failure ] crbug.com/591099 fast/css/focus-ring-continuations.html [ Failure ]
crbug.com/714962 fast/css/focus-ring-recursive-continuations.html [ Failure ] crbug.com/714962 fast/css/focus-ring-recursive-continuations.html [ Failure ]
crbug.com/714962 fast/css/focus-ring-recursive-inlines.html [ Failure ] crbug.com/714962 fast/css/focus-ring-recursive-inlines.html [ Failure ]
...@@ -1108,12 +1106,8 @@ crbug.com/591099 fast/css/getComputedStyle/getComputedStyle-resolved-values.html ...@@ -1108,12 +1106,8 @@ crbug.com/591099 fast/css/getComputedStyle/getComputedStyle-resolved-values.html
crbug.com/714962 fast/css/hover-pseudo-element-quirks.html [ Failure ] crbug.com/714962 fast/css/hover-pseudo-element-quirks.html [ Failure ]
crbug.com/591099 fast/css/import_with_baseurl.html [ Failure ] crbug.com/591099 fast/css/import_with_baseurl.html [ Failure ]
crbug.com/591099 fast/css/large-numbers.html [ Timeout ] crbug.com/591099 fast/css/large-numbers.html [ Timeout ]
crbug.com/591099 fast/css/last-child-pseudo-class.html [ Failure ]
crbug.com/591099 fast/css/last-of-type-pseudo-class.html [ Failure ]
crbug.com/591099 fast/css/margin-top-bottom-dynamic.html [ Failure ] crbug.com/591099 fast/css/margin-top-bottom-dynamic.html [ Failure ]
crbug.com/591099 fast/css/negative-text-indent-in-inline-block.html [ Failure ] crbug.com/591099 fast/css/negative-text-indent-in-inline-block.html [ Failure ]
crbug.com/591099 fast/css/only-child-pseudo-class.html [ Failure ]
crbug.com/591099 fast/css/only-of-type-pseudo-class.html [ Failure ]
crbug.com/591099 fast/css/outline-auto-empty-rects.html [ Failure ] crbug.com/591099 fast/css/outline-auto-empty-rects.html [ Failure ]
crbug.com/591099 fast/css/outline-narrowLine.html [ Failure ] crbug.com/591099 fast/css/outline-narrowLine.html [ Failure ]
crbug.com/714962 fast/css/outline-small-visual-overflow.html [ Failure ] crbug.com/714962 fast/css/outline-small-visual-overflow.html [ Failure ]
......
layer at (0,0) size 800x600 clip at (0,0) size 785x600 scrollHeight 1649
LayoutView at (0,0) size 800x600
layer at (0,0) size 785x1649 backgroundClip at (0,0) size 785x600 clip at (0,0) size 785x600
LayoutNGBlockFlow {HTML} at (0,0) size 785x1649
LayoutNGBlockFlow {BODY} at (8,16) size 769x1585 [bgcolor=#FFFFFF]
LayoutNGBlockFlow {P} at (0,0) size 769x19
LayoutText {#text} at (0,0) size 165x18
text run at (0,0) width 165: "This page is part of the "
LayoutInline {A} at (0,0) size 73x18 [color=#0000EE]
LayoutText {#text} at (165,0) size 73x18
text run at (165,0) width 73: "CSS3.info"
LayoutText {#text} at (238,0) size 4x18
text run at (238,0) width 4: " "
LayoutInline {A} at (0,0) size 131x18 [color=#0000EE]
LayoutText {#text} at (242,0) size 131x18
text run at (242,0) width 131: "CSS selectors test"
LayoutText {#text} at (373,0) size 133x18
text run at (373,0) width 133: ". See more info on "
LayoutInline {A} at (0,0) size 111x18 [color=#0000EE]
LayoutText {#text} at (506,0) size 111x18
text run at (506,0) width 111: "CSS3 selectors"
LayoutText {#text} at (617,0) size 4x18
text run at (617,0) width 4: "."
LayoutNGBlockFlow {DIV} at (0,35) size 769x0 [bgcolor=#009900]
LayoutNGBlockFlow {OL} at (0,35) size 769x1550
LayoutNGListItem {LI} at (40,0) size 615.19x248 [bgcolor=#AAAAAA]
LayoutNGListMarker (anonymous) at (-17,56.50) size 17x19
LayoutText (anonymous) at (0,0) size 17x18
text run at (0,0) width 17: "1. "
LayoutNGBlockFlow {DIV} at (16,16) size 583.19x24 [bgcolor=#990000]
LayoutNGBlockFlow {DIV} at (0,0) size 583.19x24 [bgcolor=#009900]
LayoutNGBlockFlow {PRE} at (16,53) size 583.19x109 [bgcolor=#FFFFFF]
LayoutText {#text} at (6,6) size 137x97
text run at (6,6) width 137: "div :only-child {"
text run at (142,6) width 1: " "
text run at (6,22) width 9: "}"
text run at (14,22) width 1: " "
text run at (6,38) width 1: " "
text run at (6,54) width 41: "<div>"
text run at (46,54) width 1: " "
text run at (6,70) width 113: " <div></div>"
text run at (118,70) width 1: " "
text run at (6,86) width 49: "</div>"
LayoutNGBlockFlow {P} at (16,178) size 583.19x38
LayoutText {#text} at (0,0) size 572x37
text run at (0,0) width 572: "The CSS selector should match the inner div element, because it is the only child"
text run at (0,19) width 165: "of the outer div element"
LayoutNGListItem {LI} at (40,296) size 615.19x264 [bgcolor=#AAAAAA]
LayoutNGListMarker (anonymous) at (-17,56.50) size 17x19
LayoutText (anonymous) at (0,0) size 17x18
text run at (0,0) width 17: "2. "
LayoutNGBlockFlow {DIV} at (16,16) size 583.19x24 [bgcolor=#990000]
LayoutNGBlockFlow {DIV} at (0,0) size 583.19x24 [bgcolor=#009900]
LayoutNGBlockFlow {PRE} at (16,53) size 583.19x125 [bgcolor=#FFFFFF]
LayoutText {#text} at (6,6) size 209x113
text run at (6,6) width 137: "div :only-child {"
text run at (142,6) width 1: " "
text run at (6,22) width 9: "}"
text run at (14,22) width 1: " "
text run at (6,38) width 1: " "
text run at (6,54) width 41: "<div>"
text run at (46,54) width 1: " "
text run at (6,70) width 113: " <div></div>"
text run at (118,70) width 1: " "
text run at (6,86) width 209: " <!-- Just a comment -->"
text run at (214,86) width 1: " "
text run at (6,102) width 49: "</div>"
LayoutNGBlockFlow {P} at (16,194) size 583.19x38
LayoutText {#text} at (0,0) size 572x37
text run at (0,0) width 572: "The CSS selector should match the inner div element, because it is the only child"
text run at (0,19) width 165: "of the outer div element"
LayoutNGListItem {LI} at (40,608) size 615.19x283 [bgcolor=#AAAAAA]
LayoutNGListMarker (anonymous) at (-17,40) size 17x19
LayoutText (anonymous) at (0,0) size 17x18
text run at (0,0) width 17: "3. "
LayoutNGBlockFlow {DIV} at (16,16) size 583.19x43 [bgcolor=#990000]
LayoutNGBlockFlow {DIV} at (0,0) size 583.19x24 [bgcolor=#009900]
LayoutNGBlockFlow (anonymous) at (0,24) size 583.19x19
LayoutText {#text} at (0,0) size 4x18
text run at (0,0) width 4: "."
LayoutNGBlockFlow {PRE} at (16,72) size 583.19x125 [bgcolor=#FFFFFF]
LayoutText {#text} at (6,6) size 225x113
text run at (6,6) width 137: "div :only-child {"
text run at (142,6) width 1: " "
text run at (6,22) width 9: "}"
text run at (14,22) width 1: " "
text run at (6,38) width 1: " "
text run at (6,54) width 41: "<div>"
text run at (46,54) width 1: " "
text run at (6,70) width 113: " <div></div>"
text run at (118,70) width 1: " "
text run at (6,86) width 225: " How about regular text..."
text run at (230,86) width 1: " "
text run at (6,102) width 49: "</div>"
LayoutNGBlockFlow {P} at (16,213) size 583.19x38
LayoutText {#text} at (0,0) size 572x37
text run at (0,0) width 572: "The CSS selector should match the inner div element, because it is the only child"
text run at (0,19) width 165: "of the outer div element"
LayoutNGListItem {LI} at (40,939) size 615.19x267 [bgcolor=#AAAAAA]
LayoutNGListMarker (anonymous) at (-17,59.50) size 17x19
LayoutText (anonymous) at (0,0) size 17x18
text run at (0,0) width 17: "4. "
LayoutNGBlockFlow {DIV} at (16,16) size 583.19x24 [bgcolor=#009900]
LayoutNGBlockFlow {DIV} at (0,0) size 583.19x24
LayoutNGBlockFlow {BLOCKQUOTE} at (40,40) size 503.19x0
LayoutNGBlockFlow {PRE} at (16,56) size 583.19x125 [bgcolor=#FFFFFF]
LayoutText {#text} at (6,6) size 225x113
text run at (6,6) width 137: "div :only-child {"
text run at (142,6) width 1: " "
text run at (6,22) width 9: "}"
text run at (14,22) width 1: " "
text run at (6,38) width 1: " "
text run at (6,54) width 49: "<div> "
text run at (54,54) width 1: " "
text run at (6,70) width 113: " <div></div>"
text run at (118,70) width 1: " "
text run at (6,86) width 225: " <blockquote></blockquote>"
text run at (230,86) width 1: " "
text run at (6,102) width 49: "</div>"
LayoutNGBlockFlow {P} at (16,197) size 583.19x38
LayoutText {#text} at (0,0) size 570x37
text run at (0,0) width 570: "The CSS selector should not match the inner div element, because it not the only"
text run at (0,19) width 34: "child"
LayoutNGListItem {LI} at (40,1254) size 615.19x296 [bgcolor=#AAAAAA]
LayoutNGListMarker (anonymous) at (-17,56.50) size 17x19
LayoutText (anonymous) at (0,0) size 17x18
text run at (0,0) width 17: "5. "
LayoutNGBlockFlow {DIV} at (16,16) size 583.19x24 [bgcolor=#009900]
LayoutNGBlockFlow {DIV} at (0,0) size 583.19x24
LayoutNGBlockFlow {DIV} at (0,24) size 583.19x0
LayoutNGBlockFlow {PRE} at (16,53) size 583.19x157 [bgcolor=#FFFFFF]
LayoutText {#text} at (6,6) size 481x145
text run at (6,6) width 137: "div :only-child {"
text run at (142,6) width 1: " "
text run at (6,22) width 9: "}"
text run at (14,22) width 1: " "
text run at (6,38) width 1: " "
text run at (6,54) width 41: "<div>"
text run at (46,54) width 1: " "
text run at (6,70) width 249: " <div id='appendChild'></div>"
text run at (254,70) width 1: " "
text run at (6,86) width 49: "</div>"
text run at (54,86) width 1: " "
text run at (6,102) width 1: " "
text run at (6,118) width 385: "var ib = document.getElementById('appendChild');"
text run at (390,118) width 1: " "
text run at (6,134) width 481: "ib.parentElement.appendChild(document.createElement(\"div\"));"
LayoutNGBlockFlow {P} at (16,226) size 583.19x38
LayoutText {#text} at (0,0) size 569x37
text run at (0,0) width 569: "The CSS selector should not match the original div element, because it is not the"
text run at (0,19) width 505: "only child anymore after another child is append by the Javascript code."
layer at (0,0) size 800x600 clip at (0,0) size 785x600 scrollHeight 1518
LayoutView at (0,0) size 800x600
layer at (0,0) size 785x1518 backgroundClip at (0,0) size 785x600 clip at (0,0) size 785x600
LayoutNGBlockFlow {HTML} at (0,0) size 785x1518
LayoutNGBlockFlow {BODY} at (8,16) size 769x1454 [bgcolor=#FFFFFF]
LayoutNGBlockFlow {P} at (0,0) size 769x19
LayoutText {#text} at (0,0) size 165x18
text run at (0,0) width 165: "This page is part of the "
LayoutInline {A} at (0,0) size 73x18 [color=#0000EE]
LayoutText {#text} at (165,0) size 73x18
text run at (165,0) width 73: "CSS3.info"
LayoutText {#text} at (238,0) size 4x18
text run at (238,0) width 4: " "
LayoutInline {A} at (0,0) size 131x18 [color=#0000EE]
LayoutText {#text} at (242,0) size 131x18
text run at (242,0) width 131: "CSS selectors test"
LayoutText {#text} at (373,0) size 133x18
text run at (373,0) width 133: ". See more info on "
LayoutInline {A} at (0,0) size 111x18 [color=#0000EE]
LayoutText {#text} at (506,0) size 111x18
text run at (506,0) width 111: "CSS3 selectors"
LayoutText {#text} at (617,0) size 4x18
text run at (617,0) width 4: "."
LayoutNGBlockFlow {DIV} at (0,35) size 769x0 [bgcolor=#009900]
LayoutNGBlockFlow {OL} at (0,35) size 769x1419
LayoutNGListItem {LI} at (40,0) size 615.19x216 [bgcolor=#AAAAAA]
LayoutNGListMarker (anonymous) at (-17,56.50) size 17x19
LayoutText (anonymous) at (0,0) size 17x18
text run at (0,0) width 17: "1. "
LayoutNGBlockFlow {DIV} at (16,16) size 583.19x24 [bgcolor=#990000]
LayoutNGBlockFlow {DIV} at (0,0) size 583.19x24 [bgcolor=#009900]
LayoutNGBlockFlow {PRE} at (16,53) size 583.19x77 [bgcolor=#FFFFFF]
LayoutText {#text} at (6,6) size 281x65
text run at (6,6) width 145: "div:only-of-type {"
text run at (150,6) width 1: " "
text run at (6,22) width 9: "}"
text run at (14,22) width 1: " "
text run at (6,38) width 1: " "
text run at (6,54) width 281: "<div>Does this element match?</div>"
LayoutNGBlockFlow {P} at (16,146) size 583.19x38
LayoutText {#text} at (0,0) size 551x37
text run at (0,0) width 551: "The CSS selector should match the marked div element, because it is the only"
text run at (0,19) width 137: "element of this type"
LayoutNGListItem {LI} at (40,264) size 615.19x232 [bgcolor=#AAAAAA]
LayoutNGListMarker (anonymous) at (-17,56.50) size 17x19
LayoutText (anonymous) at (0,0) size 17x18
text run at (0,0) width 17: "2. "
LayoutNGBlockFlow {DIV} at (16,16) size 583.19x24 [bgcolor=#990000]
LayoutNGBlockFlow {DIV} at (0,0) size 583.19x24 [bgcolor=#009900]
LayoutNGBlockFlow {BLOCKQUOTE} at (0,24) size 583.19x0 [bgcolor=#009900]
LayoutNGBlockFlow {PRE} at (16,53) size 583.19x93 [bgcolor=#FFFFFF]
LayoutText {#text} at (6,6) size 281x81
text run at (6,6) width 145: "div:only-of-type {"
text run at (150,6) width 1: " "
text run at (6,22) width 9: "}"
text run at (14,22) width 1: " "
text run at (6,38) width 1: " "
text run at (6,54) width 281: "<div>Does this element match?</div>"
text run at (286,54) width 1: " "
text run at (6,70) width 201: "<blockquote></blockquote>"
LayoutNGBlockFlow {P} at (16,162) size 583.19x38
LayoutText {#text} at (0,0) size 551x37
text run at (0,0) width 551: "The CSS selector should match the marked div element, because it is the only"
text run at (0,19) width 137: "element of this type"
LayoutNGListItem {LI} at (40,544) size 615.19x264 [bgcolor=#AAAAAA]
LayoutNGListMarker (anonymous) at (-17,56.50) size 17x19
LayoutText (anonymous) at (0,0) size 17x18
text run at (0,0) width 17: "3. "
LayoutNGBlockFlow {DIV} at (16,16) size 583.19x24 [bgcolor=#990000]
LayoutNGBlockFlow {DIV} at (0,0) size 583.19x24 [bgcolor=#009900]
LayoutNGBlockFlow {BLOCKQUOTE} at (0,24) size 583.19x0 [bgcolor=#009900]
LayoutNGBlockFlow {DIV} at (0,0) size 583.19x0
LayoutNGBlockFlow {PRE} at (16,53) size 583.19x125 [bgcolor=#FFFFFF]
LayoutText {#text} at (6,6) size 281x113
text run at (6,6) width 145: "div:only-of-type {"
text run at (150,6) width 1: " "
text run at (6,22) width 9: "}"
text run at (14,22) width 1: " "
text run at (6,38) width 1: " "
text run at (6,54) width 281: "<div>Does this element match?</div>"
text run at (286,54) width 1: " "
text run at (6,70) width 97: "<blockquote>"
text run at (102,70) width 1: " "
text run at (6,86) width 113: " <div></div>"
text run at (118,86) width 1: " "
text run at (6,102) width 105: "</blockquote>"
LayoutNGBlockFlow {P} at (16,194) size 583.19x38
LayoutText {#text} at (0,0) size 551x37
text run at (0,0) width 551: "The CSS selector should match the marked div element, because it is the only"
text run at (0,19) width 230: "element of this type in this scope"
LayoutNGListItem {LI} at (40,856) size 615.19x232 [bgcolor=#AAAAAA]
LayoutNGListMarker (anonymous) at (-17,56.50) size 17x19
LayoutText (anonymous) at (0,0) size 17x18
text run at (0,0) width 17: "4. "
LayoutNGBlockFlow {DIV} at (16,16) size 583.19x24 [bgcolor=#009900]
LayoutNGBlockFlow {DIV} at (0,0) size 583.19x24
LayoutNGBlockFlow {DIV} at (0,24) size 583.19x0
LayoutNGBlockFlow {PRE} at (16,53) size 583.19x93 [bgcolor=#FFFFFF]
LayoutText {#text} at (6,6) size 281x81
text run at (6,6) width 145: "div:only-of-type {"
text run at (150,6) width 1: " "
text run at (6,22) width 9: "}"
text run at (14,22) width 1: " "
text run at (6,38) width 1: " "
text run at (6,54) width 281: "<div>Does this element match?</div>"
text run at (286,54) width 1: " "
text run at (6,70) width 89: "<div></div>"
LayoutNGBlockFlow {P} at (16,162) size 583.19x38
LayoutText {#text} at (0,0) size 569x37
text run at (0,0) width 569: "The CSS selector should not match the marked div element, because it is not the"
text run at (0,19) width 171: "only element of this type"
LayoutNGListItem {LI} at (40,1136) size 615.19x283 [bgcolor=#AAAAAA]
LayoutNGListMarker (anonymous) at (-17,56.50) size 17x19
LayoutText (anonymous) at (0,0) size 17x18
text run at (0,0) width 17: "5. "
LayoutNGBlockFlow {DIV} at (16,16) size 583.19x24 [bgcolor=#009900]
LayoutNGBlockFlow {DIV} at (0,0) size 583.19x24
LayoutNGBlockFlow {DIV} at (0,24) size 583.19x0
LayoutNGBlockFlow {PRE} at (16,53) size 583.19x125 [bgcolor=#FFFFFF]
LayoutText {#text} at (6,6) size 481x113
text run at (6,6) width 145: "div:only-of-type {"
text run at (150,6) width 1: " "
text run at (6,22) width 9: "}"
text run at (14,22) width 1: " "
text run at (6,38) width 1: " "
text run at (6,54) width 225: "<div id='appendChild'></div>"
text run at (230,54) width 1: " "
text run at (6,70) width 1: " "
text run at (6,86) width 385: "var ib = document.getElementById('appendChild');"
text run at (390,86) width 1: " "
text run at (6,102) width 481: "ib.parentElement.appendChild(document.createElement(\"div\"));"
LayoutNGBlockFlow {P} at (16,194) size 583.19x57
LayoutText {#text} at (0,0) size 569x56
text run at (0,0) width 569: "The CSS selector should not match the original div element, because it is not the"
text run at (0,19) width 555: "only of its type anymore after another child with the same type is append by the"
text run at (0,38) width 115: "Javascript code."
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment