Commit f29c539e authored by Robert Liao's avatar Robert Liao Committed by Commit Bot

Disable Visibility Animations for interactive_ui_tests ConstrainedWindowViewTest

ConstrainedWindowViewTest.[TabMoveTest|ClosesOnEscape] are flaky on Mac
when animations are enabled.

BUG=823909

Change-Id: I53b5a042874e56aec0b2b82cc2e0d5a3a0e8a402
Reviewed-on: https://chromium-review.googlesource.com/972359Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544732}
parent 16df02b6
......@@ -155,6 +155,8 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, TabMoveTest) {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
std::unique_ptr<TestDialog> dialog = ShowModalDialog(web_contents);
// On Mac, animations cause this test to be flaky.
dialog->GetWidget()->SetVisibilityChangedAnimationsEnabled(false);
EXPECT_TRUE(dialog->GetWidget()->IsVisible());
// Move the tab to a second browser window; but first create another tab.
......@@ -181,6 +183,8 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, TabMoveTest) {
IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, ClosesOnEscape) {
std::unique_ptr<TestDialog> dialog =
ShowModalDialog(browser()->tab_strip_model()->GetActiveWebContents());
// On Mac, animations cause this test to be flaky.
dialog->GetWidget()->SetVisibilityChangedAnimationsEnabled(false);
EXPECT_TRUE(dialog->GetWidget()->IsVisible());
EXPECT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_ESCAPE,
false, false, false, false));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment