Commit f2a2ebd3 authored by Sylvain Defresne's avatar Sylvain Defresne Committed by Commit Bot

Convert //ui to not depend on set_sources_assignment_filter()

set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Convert BUILD.gn files below //ui to instead use conditional
to include source files only on the platformn where they are
used.

The conversion was done by using a modified version of gn that
display all files filtered by set_sources_assignment_filter()
and updating the BUILD.gn files manually to explicitly add the
source files only on the platform that used them.

This CL was uploaded by git cl split.

Bug: 1018739
Change-Id: Ibb7dafa9011c83fb40a268b7484984fe121cc934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929824Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718579}
parent 409897d0
......@@ -4,6 +4,12 @@
import("//build/config/jumbo.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See build/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
jumbo_component("range") {
sources = [
"gfx_range_export.h",
......@@ -11,14 +17,14 @@ jumbo_component("range") {
"range.h",
"range_f.cc",
"range_f.h",
"range_mac.mm",
"range_win.cc",
]
if (is_ios) {
set_sources_assignment_filter([])
if (is_win) {
sources += [ "range_win.cc" ]
}
if (is_ios || is_mac) {
sources += [ "range_mac.mm" ]
set_sources_assignment_filter(sources_assignment_filter)
}
configs += [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment