Change new library/class/interface ids to be dynamically generated.

All the new library/class/interface ids in the BUILD file are now
dynamically generated by midl, based off the product name and current
version.

Bug: 1109612
Change-Id: I3f0806c7266184c78fd61ff25ac511834dc2ed56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530525Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826316}

chrome/updater/app/server/win/BUILD.gn

@@ -4,34 +4,33 @@
 
 import("//build/toolchain/win/midl.gni")
 import("//build/util/version.gni")
-
-UpdaterClass_replaceable_uuid =
-    "PLACEHOLDER-GUID-158428a4-6014-4978-83ba-9fad0dabe791"
-IUpdater_replaceable_uuid =
-    "PLACEHOLDER-GUID-63B8FFB1-5314-48C9-9C57-93EC8BC6184B"
-
-# TODO(crbug.com/1099904): this CLSID needs to be regenerated for every build.
-# TODO(crbug.com/1099904): we need to use an indirection mechanism for the
-# common GUIDs in the SxS versions.
-#updater_clsid = "3d852661-c795-4d20-9b95-5561e9a1d2d9"
-IUPDATER_IID = "D0E1CACC-C63C-4192-94AB-BF8EAD0E3B83"
+import("//chrome/updater/branding.gni")
+
+placeholder_guids = [
+  "PLACEHOLDER-GUID-69464FF0-D9EC-4037-A35F-8AE4358106CC",  # UpdaterLib
+  "PLACEHOLDER-GUID-158428a4-6014-4978-83ba-9fad0dabe791",  # UpdaterClass
+  "PLACEHOLDER-GUID-63B8FFB1-5314-48C9-9C57-93EC8BC6184B",  # IUpdater
+  "PLACEHOLDER-GUID-46ACF70B-AC13-406D-B53B-B2C4BF091FF6",  # IUpdateState
+  "PLACEHOLDER-GUID-2FCD14AF-B645-4351-8359-E80A0E202A0B",  # ICompleteStatus
+  "PLACEHOLDER-GUID-7B416CFD-4216-4FD6-BD83-7C586054676E",  # IUpdaterObserver
+  "PLACEHOLDER-GUID-526DA036-9BD3-4697-865A-DA12D37DFFCA",  # IUpdaterControl
+  "PLACEHOLDER-GUID-D272C794-2ACE-4584-B993-3B90C622BE65",  # IUpdaterControlCallback
+]
+
+uuid5_guids = []
+foreach(guid, placeholder_guids) {
+  uuid5_guids +=
+      [ guid + "=uuid5:$updater_product_full_name$chrome_version_full" ]
+}
+uuid5_guids = string_join(",", uuid5_guids)
 
 midl("updater_idl_idl") {
-  dynamic_guids = "ignore_proxy_stub," +
-                  "$UpdaterClass_replaceable_uuid=uuid5:$chrome_version_full," +
-                  "$IUpdater_replaceable_uuid=uuid5:$chrome_version_full"
+  dynamic_guids = "ignore_proxy_stub," + uuid5_guids
 
   header_file = "updater_idl.h"
   sources = [ "updater_idl.template" ]
 
   defines = [
-    "IUPDATESTATE_IID=46ACF70B-AC13-406D-B53B-B2C4BF091FF6",
-    "ICOMPLETESTATUS_IID=2FCD14AF-B645-4351-8359-E80A0E202A0B",
-    "IUPDATEROBSERVER_IID=7B416CFD-4216-4FD6-BD83-7C586054676E",
-    "IUPDATER_IID=$IUPDATER_IID",
-    "IUPDATERCONTROL_IID=526DA036-9BD3-4697-865A-DA12D37DFFCA",
-    "IUPDATERCONTROLCALLBACK_IID=D272C794-2ACE-4584-B993-3B90C622BE65",
-    "UPDATER_LIB_UUID=69464FF0-D9EC-4037-A35F-8AE4358106CC",
     "ICURRENTSTATE_IID=247954F9-9EDC-4E68-8CC3-150C2B89EADF",
     "IGOOGLEUPDATE3WEB_IID=494B20CF-282E-4BDD-9F5D-B70CB09D351E",
     "IAPPBUNDLEWEB_IID=DD42475D-6D46-496a-924E-BD5630B4CBBA",

chrome/updater/app/server/win/updater_idl.template

@@ -216,7 +216,7 @@ interface IAppWeb : IDispatch {
 [
   object,
   dual,
-  uuid(IUPDATERCONTROLCALLBACK_IID),
+  uuid(PLACEHOLDER-GUID-D272C794-2ACE-4584-B993-3B90C622BE65),
   helpstring("IUpdaterControlCallback Interface"),
   pointer_default(unique)
 ]
@@ -227,7 +227,7 @@ interface IUpdaterControlCallback : IUnknown {
 [
   object,
   dual,
-  uuid(IUPDATERCONTROL_IID),
+  uuid(PLACEHOLDER-GUID-526DA036-9BD3-4697-865A-DA12D37DFFCA),
   helpstring("IUpdaterControl Interface"),
   pointer_default(unique)
 ]
@@ -240,7 +240,7 @@ interface IUpdaterControl : IUnknown {
 [
   object,
   dual,
-  uuid(IUPDATESTATE_IID),
+  uuid(PLACEHOLDER-GUID-46ACF70B-AC13-406D-B53B-B2C4BF091FF6),
   helpstring("IUpdateState Interface"),
   pointer_default(unique)
 ]
@@ -259,7 +259,7 @@ interface IUpdateState : IUnknown {
 [
   object,
   dual,
-  uuid(ICOMPLETESTATUS_IID),
+  uuid(PLACEHOLDER-GUID-2FCD14AF-B645-4351-8359-E80A0E202A0B),
   helpstring("ICompleteStatus Interface"),
   pointer_default(unique)
 ]
@@ -271,7 +271,7 @@ interface ICompleteStatus : IUnknown {
 [
   object,
   oleautomation,
-  uuid(IUPDATEROBSERVER_IID),
+  uuid(PLACEHOLDER-GUID-7B416CFD-4216-4FD6-BD83-7C586054676E),
   helpstring("IUpdaterObserver Interface"),
   pointer_default(unique)
 ]
@@ -301,7 +301,7 @@ interface IUpdater : IUnknown {
 };
 
 [
-  uuid(UPDATER_LIB_UUID),
+  uuid(PLACEHOLDER-GUID-69464FF0-D9EC-4037-A35F-8AE4358106CC),
   version(1.0),
   helpstring("Omaha 4.0 Type Library")
 ]