Commit f2cd82ea authored by Sam Dallstream's avatar Sam Dallstream Committed by Commit Bot

Fix for bug causing websites to crash when speaking an empty utterance

The existing code was missing a null check before passing an object
to a mojo pipeline.

Bug: 1021301
Change-Id: I9845fdcf6b6f58e593ebafc0ba548dc1e4d00330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900148
Commit-Queue: Samuel Dallstream <sadallst@microsoft.com>
Reviewed-by: default avatarPhilip Jägenstedt <foolip@chromium.org>
Reviewed-by: default avatarTommi <tommi@chromium.org>
Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715757}
parent 45623289
......@@ -123,6 +123,8 @@ void SpeechSynthesisUtterance::Start(SpeechSynthesis* synthesis) {
mojom_utterance_->Clone();
if (mojom_utterance_to_send->voice.IsNull())
mojom_utterance_to_send->voice = String("");
if (mojom_utterance_to_send->text.IsNull())
mojom_utterance_to_send->text = String("");
receiver_.reset();
......
......@@ -2746,9 +2746,6 @@ crbug.com/618969 external/wpt/css/css-grid/subgrid/ [ Skip ]
crbug.com/1012627 [ Win7 ] external/wpt/css/css-text/line-breaking/line-breaking-021.html [ Failure ]
crbug.com/1022141 external/wpt/speech-api/SpeechSynthesis-speak-events.html [ Crash Timeout ]
crbug.com/1022141 virtual/speech-with-unified-autoplay/external/wpt/speech-api/SpeechSynthesis-speak-events.html [ Crash Timeout ]
# ====== New tests from wpt-importer added here ======
crbug.com/626703 [ Linux ] external/wpt/css/css-align/baseline-rules/synthesized-baseline-table-cell-001.html [ Failure ]
crbug.com/626703 [ Mac ] external/wpt/css/css-align/baseline-rules/synthesized-baseline-table-cell-001.html [ Failure ]
......@@ -3303,9 +3300,7 @@ crbug.com/626703 external/wpt/css/vendor-imports/mozilla/mozilla-central-reftest
crbug.com/626703 external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-justify-content-horiz-006.xhtml [ Failure ]
crbug.com/626703 external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-align-content-horiz-002.xhtml [ Failure ]
crbug.com/875411 external/wpt/svg/text/reftests/text-shape-inside-002.svg [ Failure ]
crbug.com/626703 external/wpt/speech-api/SpeechSynthesis-speak-twice.html [ Timeout ]
crbug.com/626703 external/wpt/speech-api/SpeechSynthesis-speak-without-activation-fails.tentative.html [ Failure ]
crbug.com/626703 virtual/speech-with-unified-autoplay/external/wpt/speech-api/SpeechSynthesis-speak-twice.html [ Timeout ]
crbug.com/366553 external/wpt/svg/text/reftests/text-inline-size-007.svg [ Failure ]
crbug.com/366553 external/wpt/svg/text/reftests/text-inline-size-005.svg [ Failure ]
crbug.com/366558 external/wpt/svg/text/reftests/text-multiline-002.svg [ Failure ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment