Commit f2cef303 authored by torne@chromium.org's avatar torne@chromium.org

Really fix building android webview on mac.

The refactoring in the final patchset landed as r269766 got the
condition backwards (the pre-refactoring version worked), so we were
accidentally excluding flag only on *target* builds, instead of host
builds as intended (the target compiler supports this flag). Fix it.

BUG=321833
R=primiano@chromium.org

Review URL: https://codereview.chromium.org/296273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272511 0039d316-1c4b-4281-b951-d872f2087c98
parent 0f057427
...@@ -5231,7 +5231,7 @@ ...@@ -5231,7 +5231,7 @@
['gcc_version>=48 and android_webview_build==1 and host_os=="mac"', { ['gcc_version>=48 and android_webview_build==1 and host_os=="mac"', {
'target_defaults': { 'target_defaults': {
'target_conditions': [ 'target_conditions': [
['_toolset=="target"', { ['_toolset=="host"', {
'cflags!': [ 'cflags!': [
'-Wno-unused-local-typedefs', '-Wno-unused-local-typedefs',
], ],
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment